department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

CU - Update HandleTokenCallbackURL to a query instead of mutation and update getAuthSettings to getFirstTimeLogin and reduce redux state management. #10158

Open Sparowhawk opened 1 week ago

Sparowhawk commented 1 week ago

Comment are here https://github.com/department-of-veterans-affairs/va-mobile-app/pull/8192

But this ticket is to cover the work of updating handleTokenCallbackURL to a query instead of a mutation. Allowing us to get rid of the loginFinish and Start functions. It should also allow us to simplify the redux state management to handle some of the variables such as login, logout, loading, and syncing, by migrating those to the corresponding queries.

Once that is pulled out we can also change getAuthSettings to getFirstTimeLogin and have it return a boolean or combine it with the remaining state management stuff in the redux slice.