There are a few things here, we may consider breaking into 2 or 3 different PRs for atomic purposes:
adds ios and android bundle to the code_checks.yml file. This allows us to make sure any changes to the app arent breaking the js bundling process.
adds a set of build check work for android and ios when we change any files in their native directories. Each one has a new lane added to the fastfile, and three new yml files to make sure each check only counts once. see this for an explanation
Testing
workflows all pass and only one version runs for each platform.
Reviewer Validations
code quality, readability, etc
Should this be multiple PRs?
Once this is merged, we will need to test that a PR that does not include files from these directories fires the skip script and does not fire a duplicate action. if that works, these can be made required checks.
PR Checklist
Reviewer: Confirm the items below as you review
[x] PR is connected to issue(s)
[ ] Tests are included to cover this change (when possible)
[ ] No magic strings (All string unions follow the Union -> Constant type pattern)
[ ] No secrets or API keys are checked in
[ ] All imports are absolute (no relative imports)
[ ] New functions and Redux work have proper TSDoc annotations
Description of Change
creates processes for #8267
There are a few things here, we may consider breaking into 2 or 3 different PRs for atomic purposes:
adds ios and android bundle to the
code_checks.ymlfile. This allows us to make sure any changes to the app arent breaking the js bundling process.adds a set of build check work for android and ios when we change any files in their native directories. Each one has a new lane added to the fastfile, and three new yml files to make sure each check only counts once. see this for an explanation
Testing
workflows all pass and only one version runs for each platform.
Reviewer Validations
code quality, readability, etc Should this be multiple PRs?
Once this is merged, we will need to test that a PR that does not include files from these directories fires the skip script and does not fire a duplicate action. if that works, these can be made required checks.
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch