search

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

Backend: Investigate and Implement fix Errors around cancel appointment #2224

Closed kreek closed 2 years ago

kreek commented 2 years ago

User Story

As a developer I'd like to solve (or silence if it's not an issue) the errors around canceling of appointments so new errors are easier to find in Sentry.

Description

We have a lot of errors in Sentry from this part of the code which we either need to solve or turn down by marking the error as expected and adding it to the ignored errors list. This may require creating a custom error so that current or future errors of the same type are not ignored.

Acceptance Criteria

kpethtel commented 2 years ago

I've created draft proposal for how I think we should handle this: https://github.com/department-of-veterans-affairs/vets-api/compare/2224-cancel-appointment-error-noise?expand=1

We need to determine which of the errors in modules/mobile/config/locales/exceptions.en.yml need to be reported to sentry and which don't and apply the same change to all.

The same fix would also handle this sentry error: http://sentry.vfs.va.gov/organizations/vsp/issues/15043/?environment=production&project=3&statsPeriod=14d

kpethtel commented 2 years ago

Resolution: I suppressed sentry reporting for 409 appointment errors, since those were the error types I was seeing in sentry. The same approach I used here could be used for any other appointments error types that become problematic.