search

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

Bug: Errors mapping facilities to appointment requests #3779

Closed jperk51 closed 1 year ago

jperk51 commented 2 years ago

When appointment requests are flipped on in Prod there is a significant spike in errors. Most, if not all of them, error at the same spot in the code. appointment.new(location: Mobile::FacilitiesHelper.blank_location(appointment)) else log_missing_facility(appointment) raise Common::Exceptions::BackendServiceException, 'MOBL_502_upstream_error' <-- Here

We need to figure out what exactly is going on here and fix it so we can turn requests on permanently in Pord. The log_missing_facility method logs a bunch of info from the appointment that is throwing the error. The flipper was one from ~10:40PM EST 9/11/22 to ~12:10AM EST 9/12/22 so logs can be check from that time frame. log_missing_facility logs a lot of useful info about any appointment causing the above issue. If you need the feature flipped on again and don't have Prod flipper access let Jayson know and I can flip it back on.

Related sentry error: http://sentry.vfs.va.gov/organizations/vsp/issues/6008/?environment=production&project=3&query=is%3Aunresolved+mobile&statsPeriod=1h

Output: Fix bug with appointment requests then let Jayson know to flip the flag in Prod once the fix is in Prod.

Tonksthebear commented 2 years ago

Going to test in prod again with mobile_appointment_use_VAOS_MFS flipped on

jperk51 commented 2 years ago

With v2 coming it should fix this problem. I'm going to icebox it for now. If we end up needing to stay on v0 longer than we expected we will come back to it.

jperk51 commented 1 year ago

No longer an issue with v2