Review for a11yLabelVA Usability

dumathane commented 2 years ago

Proposed Change

a11yLabelVA is a function added by this PR. I'd like to confirm this does what we would expect and reproduces the same on Android and iOS in several locations. After confirming I'd like to identify all of the json strings we can replace with it.

Why Should We Prioritize?

Function was recently added and want to make sure it is usable and shouldn't be retired.

Coding Time Estimation

2 or 3. (3-5 hrs)

theodur commented 1 year ago

There are 42 instances of V\ufeffA and 164 instances of V-A. These are all the strings that can be replaced by the function:

claims.json

"appealDetails.viewMoreDetailsA11yLabel": "To review more details about your appeal, visit V-A .gov ",
"appealDetails.visitVAGovA11yHint": "Navigates to V-A .gov claims and appeals. This page will open in your device's browser",
"appealDetails.visitVAGovA11yLabel": "Visit V-A .gov",
"askForClaimDecision.haveSubmittedAllEvidenceA11yLabel": "I have submitted all evidence that will support my claim and I’m not going to turn in any more information. I would like V-A to make a decision on my claim based on the information already provided. (Required)",
"askForClaimDecision.whetherYouGetVABenefitsA11yLabel": "Whether you get V-A benefits",
"claimDetails.callVA.a11yLabel": "Call our V-A benefits hotline. We’re here Monday through Friday, 8 a.m. to 9 p.m. E-T.",
"claimPhase.details.phaseOneA11yLabel": "Thank you. V-A received your claim",
"claimDetails.reviewLocationsA11yHint": "Navigates you to the V-A claim exam page. This page will open in your device's browser",
"claimDetails.whatShouldIDoIfDisagree.a11yLabel": "What should I do if I disagree with V-A's decision on my disability claim?",
"claimsDetails.whatDoIDoIfDisagreement.header": "What should I do if I disagree with your decision on my V\ufeffA disability claim?",
"claimDetails.whyWeCombine.a11yLabel": "Why does V-A sometimes combine claims?",
"claimPhase.youHaveFileRequest": "You have {{numberOfRequests}} file request from V\ufeffA",
"claimPhase.youHaveFileRequests": "You have {{numberOfRequests}} file requests from V\ufeffA",
"claimPhase.youHaveFileRequestA11yHint": "You have {{numberOfRequests}} file request from V-A",
"claimPhase.youHaveFileRequestsA11yHint": "You have {{numberOfRequests}} file requests from V-A",
"claimDetails.yourRepresentative.a11yLabel": "Your representative for V-A claims",
"claimsAndAppeals.noClaimsAndAppealsAccess.body.a11yLabel": "We're sorry. We can't find any claims for you in our records. If you think this is an error, call the V-A benefits hotline.",
"fileUpload.accessibilityAlert.body.a11y": "We currently do not have the technology that assists screen readers in uploading pictures. You may want to upload your evidence on V-A .gov",
"fileUpload.goToVaGov": "Go to V\ufeffA.gov",
"fileUpload.goToVaGov.a11yLabel": "Go to V-A.gov",
"fileUpload.ifMoreThan10.a11y": "You can add up to 10 photos. If you need to submit a file that's more than 10 pages, you may want to upload your file on V-A dot guv.",

common.json

"downtime.message": "{{featureName}} on V\ufeffA mobile app is currently unavailable. We’re working to fix this. We intend to restore this by {{endTime}}. Please check back soon.",
"errors.callHelpCenter.informationLine.a11yLabel": "If the app still doesn't work, call our My V-A 4 1 1 main information line. We're here 24 7.",
"leavingApp.body": "You're going to a website outside of the V\ufeffA: Health and Benefits app.",
"errors.callHelpCenter.vaAppNotWorking": "The V\ufeffA mobile app isn't working right now",
"goToMyVAHealth.a11yLabel": "Go to My V-A Health",

health.json

"cernerAlert.footer": "To manage your health care with My V\uFEFFA Health providers please go to the My V\uFEFFA Health website:",
"cernerAlert.footer.a11yLabel": "To manage your health care with My V-A Health providers please go to the My V-A Health website:",
"cernerAlert.header.some": "Some of your V\uFEFFA health care team may be using the My V\uFEFFA Health portal",
"cernerAlert.header.some.a11yLabel": "Some of your V-A health care team may be using the My V-A Health portal",
"cernerAlert.header.all": "Your V\uFEFFA health care team may be using the My V\uFEFFA Health portal",
"cernerAlert.header.all.a11yLabel": "Your V-A health care team may be using the My V-A Health portal",
"cernerAlert.nowUsing": "Now using My V\uFEFFA Health",
"covid19Updates.subText": "Get the latest COVID-19 updates on V\ufeffA.gov",
"noAppointments.visitVAA11yLabel": "Visit V-A .gov",
"noAppointments.youCanScheduleA11yLabel": "You can schedule an appointment on V-A .gov, or you can call your V-A medical center to schedule an appointment.",
"notEnrolledSM.bothYouAndYour.a11yLabel": "Both you and your V-A provider must be enrolled in the Secure Messaging program",
"notEnrolledSM.withSM.a11yLabel": "With Secure Messaging, you can communicate privately online with your V-A health care team.",
"notEnrolledSM.youAreEnrolled.a11yLabel": "You are enrolled in V-A health care, and",
"notEnrolledSM.youAreRegistered.a11yLabel": "You are registered as a patient at a V-A health facility, and",
"noMatch.currentlyRegisteredPatientContentA11yLabel": "Call our My V-A 411 main information line to reach your nearest V-A medical center. Tell the representative that you tried to sign in to use the health tools on V-A .gov, but you received an error message telling you that the site couldn't match your information to a V-A patient record.",
"noMatch.currentlyRegisteredPatientA11yLabel": "If you're currently registered as a patient at a V-A health facility",
"noMatch.enrolledInHealthCareContentA11yLabel": "Call our My V-A 411 main information line to reach your nearest V-A medical center.",
"noMatch.enrolledInHealthCareA11yLabel": "If you're enrolled in V-A health care, but not currently registered as a patient at a V-A health facility",
"noMatch.noMatchA11yLabel": "We're sorry. We couldn't find a match for you in our V-A patient records.",
"noMatch.notEnrolledContentA11yLabel": "You'll need to apply for V-A health care before you can register as a V-A patient.",
"noMatch.notEnrolledA11yLabel": "If you’re not enrolled in V-A health care or you don't know if you're enrolled",
"noMatch.titleA11yLabel": "We couldn't match your information to our V-A patient records",
"noVaccineRecords.alert.title": "We couldn't find information about your V\ufeffA vaccines",
"noRequestAppointmentAccess.bulletOneLabel": "Enrolled in V-A health care, and",
"noRequestAppointmentAccess.bulletTwoLabel": "Registered with at least 1 V-A medical center that accepts online scheduling",
"noRequestAppointmentAccess.findFacilityBtnHint": "Navigates to the find V-A location screen",
"pastAppointmentDetails.toScheduleAnotherAppointmentA11yLabel": "To schedule another appointment, please visit V-A .gov or call your V-A medical center.",
"requestAppointment.typeOfCareNotListedYoureNotLabel": "You're not registered at a V-A health facility that offers these types of care:",
"requestAppointment.typeOfCareNotListedForTheseTypeOfCareLabel": "For these types of care, you'll need to call a V-A health facility to schedule.",
"requestAppointment.typeOfCareNotListedFindfVaLinkLabel": "Find a V-A location",
"requestAppointment.whichFacilityLabel": "Which V-A facility do you prefer?",
"prescription.A11yHint": "Go to the V-A Prescription tool",
"prescription.subText.a11yLabel": "Refill and track your V-A prescriptions",
"prescription.details.banner.bullet1.a11yLabel": "Use My V-A Health portal,",
"prescription.details.banner.bullet2.a11yLabel": "Contact your local V-A pharmacy,",
"prescription.details.vaFacilityHeaderLabel": "V-A facility",
"prescription.help.footer.a11yLabel": "If you have questions about your V-A prescriptions, call the V-A pharmacy number on your prescription label.",
"prescription.history.empty.filtered.all.a11y": "We can’t find any V-A prescriptions that match your filter selection. Try changing or resetting the filter.",
"prescription.history.empty.message.a11y": "We can’t find any V-A prescriptions that match the criteria for this list.",
"prescription.history.empty.pending.message.a11y": "This list will only show refills requests you’ve submitted or refills that the V-A pharmacy is processing.",
"prescription.history.empty.tracking.p2.a11y": "Tracking information is available 1 to 2 days after the V-A Mail Order Pharmacy refills your prescription.",
"prescription.history.transferred.instructions.a11y": "Some V-A health facilities use a new electronic health record system. We transferred prescriptions from these facilities to the My V-A Health portal.",
"prescriptions.header.helper.all.a11y": "This list only shows your V-A prescriptions and isn’t intended to be a plan of care.",
"prescriptions.header.helper.pending.a11y": "This list shows refill requests that you have submitted. It also shows refills that the V-A pharmacy is processing.",
"prescriptions.loading.a11yLabel": "Loading your V-A prescriptions…",
"prescriptions.notAuthorized.warning.a11y": "You can't access your V-A prescriptions",
"prescriptions.notAuthorized.enrolled.a11y": "You're enrolled in V-A health care,",
"prescriptions.notAuthorized.registered.a11y": "You're registered as a patient at a V-A health facility.",
"prescriptions.notFound.title.a11y": "We can't find any V-A prescriptions for you",
"prescriptions.notFound.yourVA.a11y": "Your V-A prescription list in the app won’t include:",
"prescriptions.refillRequestSummary.tryAgain.a11yLabel": "We're sorry. Something went wrong on our end. Try again or contact your local V-A pharmacy.",
"prescriptions.refillRequestSummary.yourRefills.successPt1.a11y": "We're reviewing your refill request. Once approved, the V-A pharmacy will process your refill.",
"prescriptions.refillRequestSummary.yourRefills.successPt2.a11y": "If you have questions about the status of your refill, contact your provider or local V-A pharmacy.",
"prescription.vaFacility.a11yLabel": "V-A facility:",
"secureMessaging.composeMessage.bothYouAndProviderMustBeEnrolledA11yLabel": "We're sorry. To send a Secure Message, both you and your V-A primary care provider must be enrolled in the Secure Messaging program. Please contact your primary care provider to see if they are enrolled and can enroll you in the program.",
"secureMessaging.composeMessage.pleaseCallHealthProviderA11yLabel": "Important: Please call your V-A health care provider if you have an urgent health need.",
"secureMessaging.composeMessage.threeDaysToReceiveResponseA11yLabel": "It can take up to three business days to receive a response from a member of your health care team or the administrative V-A staff member you contacted.",
"secureMessaging.attachments.FAQ.ifYourProblemA11y": "If your problem persists, please contact the My Healthy Vet Help Desk. We're here Monday-Friday, 8:00 a.m.\ufeff8:00 p.m. E\ufeffT.",
"secureMessaging.inbox.noMessages.body.a11y": "Compose a message to ask non urgent (non-emergency) health related questions, send updates, manage appointments, and request referrals and medication refills from your V-A health care team.",
"prescriptions.noRefill.text.a11yLabel": "This list only includes prescriptions that have 1 or more refills available. If you think this is an error,  please contact your local V-A pharmacy.",
"secureMessaging.reply.error.ifYouThinkA11y": "Please contact your My Healthy Vet Coordinator at this V-A Medical Center to see if this triage group is currently participating in Secure Messaging and if you are enrolled in the triage group.",
"statusGlossary.active.a11yLabel": "A prescription that can be filled at the local V-A pharmacy. If this prescription is refillable, you may request a refill of this V-A prescription.",
"statusGlossary.active.hold.a11yLabel": "An active prescription that will not be filled until pharmacy resolves the issue. Contact your V-A pharmacy when you need more of this V-A prescription.",
"statusGlossary.active.inProgress.a11yLabel": "A refill request is being processed by the V-A pharmacy. When a prescription is in the Refill in Process status, the Fill Date will show when the prescription will be ready for delivery via mail by a V-A Mail Order Pharmacy.",
"statusGlossary.active.parked.a11yLabel": "A V-A Prescription that is on file at V-A Pharmacy and available for you to submit a fill request. This prescription may or may not have been previously filled. This prescription has been ordered by your V-A provider but will not be sent to you until you request that it is filled. You may request this medication using MyHealtheVet, Rx Refill mobile app, V-A phone service or mail in refills.",
"statusGlossary.active.submitted.a11yLabel": "The refill request has been received by My HealtheVet but has not been processed by the V-A Pharmacy yet.",
"statusGlossary.active.suspended.a11yLabel": "An active V-A Prescription that is not scheduled to be filled yet.",
"statusGlossary.discontinued.a11yLabel": "A prescription stopped by a V-A provider. It is no longer available to be filled. Contact your V-A healthcare team when you need more of this V-A prescription.",
"statusGlossary.expired.a11yLabel": "A prescription which is too old to fill. This does not refer to the expiration date of the medication in the container. Contact your V-A healthcare team when you need more of this V-A prescription.",
"statusGlossary.nonVerified.a11yLabel": "A V-A pharmacist is verifying this prescription.",
"statusGlossary.transferred.a11yLabel": "A prescription moved to V-A’s new electronic health record. This prescription may also be described as “Discontinued” on medication lists from your healthcare team. Take your medications as prescribed by your healthcare team.",
"statusGlossary.unknown.a11yLabel": "The status cannot be determined. Contact your V-A care team when you need more of this V-A prescription. A prescription stopped by a V-A provider. It is no longer available to be filled.",
"upcomingAppointmentDetails.cancelUncancellableAppointment.body.A11yLabel": "Call your V-A health facility. You can't cancel {{appointmentType}} appointments online.",
"upcomingAppointmentDetails.findYourVALocation.a11yLabel": "Find your V-A location",
"upcomingAppointmentDetails.findYourVALocation.a11yHint": "Takes you to the V-A facility locator page. This page will open in your device's browser",
"upcomingAppointmentDetails.visitVAGovA11yLabel": "Visit V-A .gov",
"upcomingAppointments.vaAppointment.a11yLabel": "V-A appointment",
"upcomingAppointmentDetails.cancelCovidVaccineAppointment.title": "To cancel this appointment, call your V\ufeffA  medical center",
"upcomingAppointmentDetails.cancelCovidVaccineAppointment.body": "COVID-19 appointments can't be canceled online. Please call the V\ufeffA facility to cancel your appointment.",
"upcomingAppointments.connectAtAtlas.a11yLabel": "V\ufeffA Video Connect at an ATLAS location",
"upcomingAppointments.connectAtHome.a11yLabel": "V\ufeffA Video Connect at home",
"upcomingAppointments.connectGFE.a11yLabel": "V\ufeffA Video Connect using a VA device",
"upcomingAppointments.connectOnsite.a11yLabel": "V\ufeffA Video Connect at a VA location",
"vaccines.details.title": "V\uFEFFA Vaccine Detail",
"vaccines.details.weBaseThis": "We base this information on your current V\ufeffA health records. If you have any questions, contact your health care team.",
"vaccines.list.a11y": "Review your V\uFEFFA vaccine record",
"vaImmunizations.a11yHint": "Review your V\ufeffA immunization record",
"vaImmunizations.subText": "View all your V\ufeffA immunizations",
"vaImmunizations.title": "V\ufeffA Immunizations",
"vaVaccines.a11yHint": "Review all your V\ufeffA vaccines",
"vaVaccines.buttonTitle": "V\ufeffA vaccine records",
"vaVaccines.subText": "Review your COVID-19 and other V\ufeffA vaccine records",
"vaVaccines.title": "V\ufeffA Vaccines"

login.json

"onboarding.getMostOfProfile": "Stay up to date with your profile by: keeping your personal contact information up to date, direct deposit with your preferred bank, obtain your letters and documentation whenever you need it, and review payments made to you by the V\ufeffA.",
"onboarding.allInformationYouNeed.a11yLabel": "With this app, you can manage your V-A health care and benefits in one location: Update your V-A .gov profile. Check the status of claims and appeals. Manage health appointments. Complete these and other V-A related tasks right on your phone.",
"onboarding.health.appointments.details.a11y": "In the health care section, you can manage your V-A appointments, message with your V-A health providers using MyHealtheVet secure messaging, and review your V-A vaccine records.",
"onboarding.health.header.a11y": "Access your V-A health care",
"onboarding.health.prescriptions.details.a11y": "In the health care section, you can refill and track your V-A prescriptions, manage your V-A appointments, message with your V-A health providers using MyHealtheVet secure messaging, and review your V-A vaccine records.",

profile.json

"disabilityRating.learnAbout.A11yLabel": "Learn about V-A disability ratings",
"disabilityRating.learnAboutLinkTitle.a11yLabel": "About V-A disability ratings",
"disabilityRating.learnAboutLinkTitle.a11yHint": "Learn more about V-A disability ratings",
"disabilityRating.learnAboutSummary.a11yLabel": "To learn how we determined your V-A combined disability rating, use our disability rating calculator and ratings table.",
"directDeposit.viewAndEditTextA11yLabel": "Add, review, or change your direct deposit information for disability compensation and pension benefits. Any updates you make here will also update on V-A .gov .",
"editAddress.validation.confirmAddress.noSuggestions.body.a11yLabel": "We couldn't confirm your address with the U-S Postal Service. Verify your address so we can save it to your V-A profile. If the address you entered isn't correct, edit it. If the address listed below is correct, select it.",
"editAddress.validation.confirmAddress.suggestions.body.a11yLabel": "We couldn't confirm your address with the U-S Postal Service. Verify your address so we can save it to your V-A profile. If the address you entered isn't correct, edit it or choose a suggested address below.",
"howDoIUpdate.findYourNearestVALocationA11yLabel": "Find your nearest V-A location",
"howDoIUpdate.findYourNearestVALocationA11yHint": "Takes you to the V-A Facility Locator page",
"lettersAndDocs.a11yHint": "Go to the V-A letters and documents page",
"lettersAndDocs.title.a11yLabel": "V-A letters and documents",
"letters.benefitService.benefitAndDisabilityInfoA11yLabel": "V-A disability rating and compensation information",
"letters.benefitService.sendMessageA11yLabel": "Go to Ask V-A",
"letters.benefitService.sendMessageA11yHint": "Takes you to the Ask V-A page. This page will open in your device's browser",
"letters.benefitService.sendMessageIfIncorrectInfoA11yLabel": "If your service period or disability status information is incorrect, contact us online through Ask V-A.",
"letters.benefitVerificationA11yLabel.description": "This letter shows the benefits you’re receiving from V-A . The letter also shows your benefit gross amount (the amount before anything is taken out) and net amount (the amount after deductions are taken out), your benefit effective date, and your disability rating.",
"letters.minimumEssentialCoverageA11yLabel.description": "This letter indicates that you have Minimum Essential Coverage (M-E-C) as provided by V-A . M-E-C means that your health care plan meets the health insurance requirements under the Affordable Care Act (A-C-A). To prove that you’re enrolled in the V-A health care system, you must have I-R-S Form 1095-B from V-A to show what months you were covered by a V-A health care plan.",
"letters.overview.viewLetters.hint": "Review a list of your V-A letters",
"militaryInformation.incorrectServiceInfo.bodyA11yLabel": "Some Veterans have reported seeing military service information in their V-A .gov profiles that doesn’t seem right. When this happens, it’s because there’s an error in the information we’re pulling into V-A .gov from the Defense Enrollment Eligibility Reporting System (DEERS).\n\nIf the military service information in your profile doesn’t look right, please call the Defense Manpower Data Center (D-M-D-C). They’ll work with you to update your information in DEERS.\n\nTo reach the D-M-D-C, call Monday through Friday (except federal holidays), 8:00 a.m. to 8:00 p.m. Eastern Time.",
"personalInformation.deleteDataInfoA11yLabel": "This will remove your {{ alertText }} across many V-A records. You can always come back to your profile later if you'd like to add this information back in.",
"personalInformation.editNoteA11yLabel": "Any updates you make here will also update in your V-A .gov profile.",
"personalInformation.howWillYouUseContactInfo.a11yLabel": "How will V-A use my contact information?"
"disabilityRating.noDisabilityRatings.title": "You do not have a V\ufeffA combined disability rating on record.",
"editPhoneNumber.remove.message": "This will remove your {{numberType}} across many V\ufeffA records. You can always come back to your profile later if you want to add this information back in.",
"howToUpdateDirectDeposit.alert.body": "We require this to protect bank account information and prevent fraud.\n\nIf you have one, please sign out and sign back in using your verified ID.me or Login.gov account.",
"payments.missingPayments.body": "V\ufeffA pays benefits on the first day of the month for the previous month. Please wait at least 3 business days (Monday through Friday) before reporting non-receipt of a payment.\n\nTo report a missing payment, contact the Veterans Help Line. We’re here Monday through Friday, 8:00 a.m. to 9:00 p.m. ET.",
"payments.noPayments.title": "We don't have a record of V\ufeffA payments for you",
"payments.noPayments.body": "We can't find any V\ufeffA payments made to you, or returned V\ufeffA payments. Some details about payments may not be available.\n\nV\ufeffA pays benefits on the first day of the month for the previous month. Please wait at least 3 business days (Monday through Friday) before reporting non-receipt of a payment.\n\nIf you think this is an error, or if you have questions about your payment history, please call the Veterans Help Line. We’re here Monday through Friday, 8:00 a.m. to 9:00 p.m. ET.",

home.json

These translations have been updated to use the a11yLabelVA function in this draft PR for ticket #2692

theodur commented 1 year ago

I tested the function in the draft PR mentioned above with the home screen translations on both iOS and Android. The home screen should give us a good idea on how this function would perform throughout the app, because most edge cases of VA usage appear on the home screen:

VA as the first word in a translation
VA as the last word in a translation
VA next to numbers (e.g. Call MyVA411)

For all VA instances, the function pronounced it correctly. I made screenshots comparing the pronunciation before using the function and after:

Note: My iOS device pronounced all of them correctly before using the function, so there aren't any differences that I noticed. Just wanted to add both before and after for transparency. Also, the audio in the recording on my Android device isn't the best, but I still uploaded what I was able to capture.