department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

WGAG: Focus not obscured (Spike/Review) #4738

Closed StacyB2023 closed 1 year ago

StacyB2023 commented 1 year ago

Description: As a mobile app user, I would like to ensure that accessibility requirements are met for Focus not obscured to ensure the best experience when using the app.

Additional Story Notations:

-Review the current compliance for Focus not Obscured which can be found here: https://www.w3.org/WAI/WCAG22/Understanding/focus-not-obscured-enhanced.html

See Notations here from group meeting with UX/ENG. Note: ENG looking into examples of overlapping

https://docs.google.com/document/d/125AHzB4CW-JAfpd4ZInCQ_QA9_x1u-vpi2QgDDpoRZg/edit#

Acceptance Criteria

StacyB2023 commented 1 year ago

https://docs.google.com/document/d/125AHzB4CW-JAfpd4ZInCQ_QA9_x1u-vpi2QgDDpoRZg/edit# Meeting Notes from 2/9/23

StacyB2023 commented 1 year ago

@kidlaurenpeace This is separate item based on the meeting we had with UX and ENG

StacyB2023 commented 1 year ago

@brea11y This is the one that had heavy discussion and recommendations. Let me know your thoughts on pulling this one into this sprint to see if we can get some ENG tickets to pull out, reccommendations etc.

brea11y commented 1 year ago

@StacyB2023 -- I think we can make some progress with this one. At the very least, I think we can get some recommendations put together.

StacyB2023 commented 1 year ago

@theodur Hi Theo, following up on this one. I know you were doing checking some possible examples for us a while back to see if this was implemented in the app (overlap from the navigation bar)

https://docs.google.com/document/d/125AHzB4CW-JAfpd4ZInCQ_QA9_x1u-vpi2QgDDpoRZg/edit#

If this is not implemented today, we wanted to check if this something that is even possible? Do buttons scroll up with content today?

cc: @brea11y

theodur commented 1 year ago

@StacyB2023 Hi Stacy, sorry for not getting back to you on this sooner! When I looked into examples of overlapping on the navigation bar in the app, I wasn't really able to find any instances of that. Previously, I know we had some issues with snackbars overlapping on the nav bar, but there was a ticket that was recently completed that fixed snackbars from overlapping on the remaining screens that had overlapping issues. It's also possible that I may be missing places where overlapping that is still happening. I'll follow up with Binny on this for some second eyes. I'll keep you posted!

StacyB2023 commented 1 year ago

@theodur Thanks theo! let us know if that changes in your chat with Bini.

cc: @brea11y @kidlaurenpeace

theodur commented 1 year ago

@StacyB2023 Following up on this, I confirmed with Binny that there shouldn't be any place in the app where the nav bar is obscured, especially with the nav changes. He wasn't able to see or think of any place in the app that has this issue. If anyone comes across examples of the navbar being obscured, please let us know! That would definitely be an unforeseen bug

StacyB2023 commented 1 year ago

@theodur Thanks for confirming the above.

@brea11y Based on the above, do you think its safe to close this one for now? Im thinking if there is a new solution we want to suggest to implement, we could backlog it? But if you and lauren feel different, we could explore.

brea11y commented 1 year ago

Absolutely. I'm okay with closing this for now. The only element that I was concerned with were the pinned buttons that we have at the bottom of some of the screens, however, I'm not currently seeing anywhere in the app where those buttons are overlapping focusable elements, so I think we're good to close and can revisit / open a ticket if we find that an overlap occurs in the future. Closing with my comment! Thanks team!!!