CU - Ensure API Error statuses/objects are logged to firebase

[dumathane]

Proposed Change

We need to ensure our logNonFatalErrorToFirebase will actually log an api error object to firebase for our review.

Why Should We Prioritize?

This will help us prioritize different api errors we are not prepared to respond with.

Coding Time Estimation

3

Testing Considerations

Checklist

• [x] Add the front-end label tag
• [ ] Attach to the Frontend epic for engineering initiatives

[TKDickson]

QA estimate: 0 points, untestable. @bischoffa

[alexandec]

I have a solution for this, but have been unable to test it because Firebase Crashlytics does not send reports during local development. I attempted to override the settings to enable sending of reports, but this failed due to our older Firebase version. Upgrading our Firebase version should allow overriding the defaults so the reports are sent. I'm marking this ticket as blocked by the Firebase upgrade.

[alexandec]

How to override the defaults and send reports: https://invertase.io/blog/react-native-firebase-crashlytics-configuration Discussion with maintainer stating that a Firebase upgrade is required to send reports for iOS debug and release builds: https://github.com/invertase/react-native-firebase/issues/6226

[alexandec]

One other note, I tried Settings -> Developer Screen -> Enable Firebase Debug Mode but that didn't work either. First step remains to update our Firebase packages to the latest version.

[alexandec]

Still blocked pending Firebase client upgrade (see above).

[bischoffa]

@alexandec can you verify we are still blocked? Also is this blocked by ticket 4145?

[alexandec]

@bischoffa that's right, this is still blocked by #4145 (Firebase client upgrade)

[bischoffa]

@timwright12 do you anticipate any major dependency work in Q4?

[bischoffa]

@timwright12 moving this to icebox as I did not see any major dependency work planned for Q4 and this has been blocked for over 3 months now.

[alexandec]

Related to this, I added an analytics event to the logNonFatalErrorToFirebase function which records all non-fatal errors along with error status, endpoint, and additional info. So even though Firebase itself is unchanged, we are accumulating a lot of useful error info. Putting the info into analytics also means we have much more flexible error reporting options. This ticket is still useful but it's less important due to the analytics error reporting.

[timwright12]

Is this still blocked? It looks like https://github.com/department-of-veterans-affairs/va-mobile-app/issues/4145 was closed out

[bischoffa]

Given untestable, I removed Therese as the assignee.

[alexandec]

@timwright12 I think Global can revisit this ticket, yep