Update Light/Dark Mode Friendly Contrast Fills for Icons

[jessicawoodin]

Description

As part of #5673, we investigated our duotone icons and determined the most contrast-friendly fills for light and dark mode.

Icons that will NOT change

Icons that should stay transparent (see images)

• Add
• ExclamationTriangle
• QuestionMark

Icons that should stay filled in (see images)

• Minus

Icons that will change

Icons that should change to transparent (see images)

• VASelector
  • CheckBoxFilled
  • CheckBoxIntermediate
  • RadioFilled
• Links
  • Calendar
  • Chat
  • CircleExternalLink
  • CirclePhone
  • Directions
  • PhoneTTY
  • RightArrowInCircle
  • Text

Icons that change depending on where they're used (see images)

• CircleCheckMark
  • Claims Row & File Requests - keep filled in to match step numbers
  • Snackbar - change to transparent
  • Rx Refill - change to transparent
    • In dark mode, change greenDarker icon color to greenLight to pass color contrast.
• Remove
  • Photo Review - keep filled in to pass color contrast
  • Rx Refill - change to transparent
• Info
  • Label Tag - keep filled in to pass color contrast
  • Add transparent option for future usage in Alert Box component

[TimRoe]

For linking issues: #5673

[TimRoe]

@kellylein FYI: went ahead and put a 3 on it for estimation since I have a good idea of what's involved both from working with Jessica and doing the preceding icon stuff. Moved it to the Backlog - Ready to Work, not sure if you wanted to instead slate for next sprint (or current that starts today?).

Edit: Also updated it to just a normal ticket, no spike research here since 4905 added the capability to do what this ticket entails.

[TKDickson]

QA estimate will also be a 3.

[timwright12]

@jessicawoodin @kellylein should this be migrated over to the design system repo? Or maybe closed out at this point?

[TimRoe]

@timwright12 Probably good for Jessica to confirm, but believe this can be closed out as VADS and USWDS do not have two tone icons (e.g. when all icons are updated, there'll be no secondary fill for contrast and it'll just be transparent to the background).

[jessicawoodin]

That's correct! I think we can close this out.