department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

CU - Investigate duplicate registerDevice calls #6926

Open dumathane opened 1 year ago

dumathane commented 1 year ago

Proposed Change

It was reported in DSVA that somehow push notification registration code is being triggered twice in rapid succession:

Rob Durkin 1 day ago @Jayson Perkins , can you think of any reason why there might be multiple simultaneous requests to the VEText endpoint that creates a mobile client (the endpoint in reference is /api/vetext/pub/mobile/push/endpoint)? VEtext checks for an existing client based on Token, but the source of this particular problem is multiple simultaneous PUT requests for the same client. The requests come within 200 msec of each other, so the invocations result in the duplicate records being persisted.

image

Why Should We Prioritize?

Should identify duplicate sends.

Coding Time Estimation

2

Testing Considerations

Checklist

[ ] Add the front-end label tag

[ ] Attach to the Frontend epic for engineering initiatives

timwright12 commented 1 year ago

@dumathane this is the original ticket for the issue: https://app.zenhub.com/workspaces/va-mobile-60f1a34998bc75000f2a489f/issues/gh/department-of-veterans-affairs/va-mobile-app/6253

let's close one of them so we don't have dupes floating around