department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
10 stars 1 forks source link

Replace react-native-file-viewer package with native module for previewing files #7007

Open theodur opened 8 months ago

theodur commented 8 months ago

Description

Based on the discovery in https://github.com/department-of-veterans-affairs/va-mobile-app/issues/6913, we aren't using much of the functionality from the react-native-file-viewer package, and the functionality that we are using is only in a few parts of the app. This makes the package a good candidate for us to implement our own custom solution, rather than adding this package to the app just for one function. We're only using the open function from the package, so this functionality is the main thing that would be needed in the native module. One thing to note is we are using the onDismiss option in the secure messaging slice, so functionality for that would need to be migrated as well.

Acceptance criteria

Sparowhawk commented 8 months ago

this one is actually a lot trickier than you would think to implement. Will get to it one of these next times for post planning adds