department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

BUG - sev-3 - All - Contact Info - remove home address confirmation is showing the accessibility callout if you enter the 'edit' screens with screenreader on #7642

Closed TKDickson closed 4 months ago

TKDickson commented 9 months ago

What happened?

If I tap into edit [specific piece of contact info, ie address, phone or email] with screen reader on, the confirmation text that appears for the remove [specific piece of contact info] will display the accessibility text (not just read it). If I tap into edit with screen reader off, I see the 'normal' text for the remove home address confirmation

iOS is showing the bug, Android is showing what I'd expect to see. Note "VA" vs " V-A " (extra spaces intentional in those quotes) in the photo:

image.png

Is this some kind of workaround we needed to have in place, in order to get "VA" to be pronounced correctly on this confirmation? Is that the best choice, or should we just have "vah" or "via" or etc instead of "vee ay"?

Specs:

Steps to Reproduce

Desired behavior

Acceptance Criteria

Bug Severity - BE SURE TO ADD THE SEVERITY LABEL

See [Bug Tracking](https://department-of-veterans-affairs.github.io/va-mobile-app/docs/QA#issue-severity) for details on severity levels

Linked to Story

Screen shot(s) and additional information

Full JSON response for services related to issue (expand/collapse)

Ticket Checklist

theodur commented 4 months ago

This is definitely a workaround to get the screen reader to pronounce "VA" correctly. The alert hook uses the a11yLabelVA function whenever the screen reader is enabled. Unfortunately, there's not a way to specify accessibility labels for native alerts.

Not sure if we need Brea to weigh in, but since only a small percentage of our users are impacted by the mispronunciation of "VA" I think it'd be better to visually represent the "VA" text correctly as opposed to visually misrepresenting it just to account for the mispronunciation issue. I made those changes in my PR for now.

TKDickson commented 4 months ago

not currently testing (over limit)

TKDickson commented 4 months ago

Picking up this ticket as one of my 3

TKDickson commented 4 months ago
image.png

Approved to merge to develop

TKDickson commented 4 months ago

Does not require further testing in develop; closing