BUG - sev-3 - All - Calling the mobile/v0/push/register API at least three times

TKDickson commented 7 months ago

What happened?

When we call the /mobile/v0/push/register API from the app (which happens during the sign-in sequence for Android, or after opt-in for iOS), we nearly always call it..... three times simultaneously.

Once - just once, like a unicorn vanishing into the mist - I saw it log five times during the login sequence on Android.

Specs:

Device:
OS:
User Account:
Accessibility State:

Steps to Reproduce

Desired behavior

Should just call it once.

Acceptance Criteria

Bug Severity - BE SURE TO ADD THE SEVERITY LABEL

See [Bug Tracking](https://department-of-veterans-affairs.github.io/va-mobile-app/docs/QA#issue-severity) for details on severity levels

Impact: High Low
Frequency: High Low

3 - Low
2 - High
1 - Critical

Linked to Story

Screen shot(s) and additional information

Full JSON response for services related to issue (expand/collapse)

Ticket Checklist

[ ] Steps to reproduce are defined
[ ] Desired behavior is added
[ ] Labels added (front-end, back-end, relevant feature, accessibility, etc)
[ ] Estimate of 1 added (for front-end tickets)
[ ] Added either to the relevant feature epic (if found during new feature implementation), or the bug epic

Sparowhawk commented 5 months ago

@TKDickson This likely will be fixed with the React Query Migration for Notifications when that gets merged you should recheck this

TKDickson commented 5 months ago

Added the notification migration ticket as a dependency.

theodur commented 1 month ago

@TKDickson Are you fine with me attaching this ticket to Dylan's RQ Notification PR and marking it as in progress? This should get resolved there with the updated RQ logic

TKDickson commented 1 month ago

@theodur yes definitely

TKDickson commented 3 weeks ago

Have been blocked on this since Tuesday - there's a reverse proxy server somewhere in the staging notification ecosystem that's not playing nicely. Hopefully resolved today.

TKDickson commented 3 weeks ago

DSVA support thread is resolved and I've confirmed I can successfully register for notifications, as well as fetch preferences, from upstream servers. This is unblocked and I can start working on it tomorrow.

TKDickson commented 2 weeks ago

During login, we're still calling the register call twice when opting into push on iOS:

If you opt-out of push during login, and then later turn it on (via jumping from the notification preferences screen in the app out to settings), then the register call is made...... dear god, 7 times:

@Sparowhawk still broken

TKDickson commented 3 days ago

This is improved, but not yet fully fixed.

When calling the push notification registration during login, it's only being called once - pass.
If enabling notifications for the first time AFTER login (by going to Profile > Settings > Notifications > Go to Device Settings, then turning on notifications and app-switching back to the H&B app), the registration call is being made twice. - improved, but still a fail.

I'm guessing it's some kind of race condition, along the lines of "the call is made once when you reach the page, and then again immediately when the page reloads because you've app-switched back into it" but I could be wrong.

TKDickson commented 3 days ago

This is fully fixed/resolved - won't be able to close until the issue on #8253 is ready, but does not require further testing.

department-of-veterans-affairs / va-mobile-app