department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
12 stars 2 forks source link

Create Disability Rating and Monthly Payment Component #7966

Closed ajsarkar28 closed 6 months ago

ajsarkar28 commented 7 months ago

Overview This ticket covers creating the new disability rating and monthly payment component. The implementation of these components is in the About you section creation and content ticket.

Component Creation

Accessibility & Content

TKDickson commented 6 months ago

Test rail cases

TKDickson commented 6 months ago

Now, Android only, we're seeing the same type of thing in the DR and $ portions as have seen previously (reads as: “disability rating 70% service connected” (swipe) “70%” (swipe) “service connected”)

TKDickson commented 6 months ago

Right now, the disability rating and military service history API calls kick off during the sync screen, but the letters beneficiary call only kicks off AFTER the home screen loads. Can we be front-loading the beneficiary call as well, to make loading the $ info on the home screen (or the entire about you section, I think, after #7968 adds the loading stuff) faster?

TKDickson commented 6 months ago

Wrote #8143 after conversation with Binny; should ideally be addressed at the same time as the API refresh/activity reloading behavior (which is still unticketed work)

TKDickson commented 6 months ago

See comment on #7940 for initial-issues-found resolution comment. It's weird because there are two tickets with a single PR.

TKDickson commented 6 months ago

With QA and VQA signoff (see the above ticket again), merged to XL and closing

TKDickson commented 6 months ago

belated test run link