Add Spaceforce SVG Icon to App

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."

https://department-of-veterans-affairs.github.io/va-mobile-app/

10 stars 1 forks source link

Add Spaceforce SVG Icon to App #8184

Closed ajsarkar28 closed 2 months ago

ajsarkar28 commented 3 months ago

AC:

Spaceforce SVG icon is added to the app
When a Veteran is a part of the Spaceforce, display the spaceforce icon in all areas of the app that display branch of service icons
Let Brea know that this has been added so the design library can be updated

dumathane commented 2 months ago

https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/site/assets/img/vic-space-force-logo.png

dumathane commented 2 months ago

Link for thread discussion: https://adhoc.slack.com/archives/C063KLSMVAR/p1711635893168319

theodur commented 2 months ago

I updated the PR to use the new SVG (Slack thread)

I confirmed the only difference between the two SVGs is the text color (and some very minor alignment of the logo above the text), so I just used the light theme logo and made the fill color changeable. This way, we only need 1 SVG in the app for SpaceForce, and can just set the fill color as we need to.

TKDickson commented 2 months ago

Logos now have appropriate contrast in light, dark and blue modes. Ready to merge.

TKDickson commented 2 months ago

Merged; closing.