search

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

Fixing React Query Downtime #8292

Closed Sparowhawk closed 7 months ago

rbontrager commented 7 months ago

Maintenance windows work but the change doesn't account for the user banner on the home screen/profile screen. So if military info/disability rating is in maintenance its still showing the branch/military seal on the banner and isn't getting rid of the fields in maintenance in the veteran status panel. Moving back to in progress for now.

Sparowhawk commented 7 months ago

I believe we are fine here as per Binny it either just works or doesn't(hidden if it doesn't). Since this data is highly unlikely to change RQ also having the ability to cache the values would actually benefit us here and make it so we wouldn't need to inform them of the downtime.

rbontrager commented 7 months ago

Talked with Binny and he says this will be fixed in home screen personalization and verified with 7967.

I confirmed that all maintenance windows work with react query and that Dylan is adding the same logic to any new react query changes.