Componentization - VA in person appointments - Detail View

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."

https://department-of-veterans-affairs.github.io/va-mobile-app/

17 stars 2 forks source link

Componentization - VA in person appointments - Detail View #8501

Closed ala-yna closed 6 months ago

ala-yna commented 7 months ago

Description

As an engineer, I want create and reuse different standardized components for appointments, so that it will easier for other teams to start working in appointments and the different appointment types can be more aligned.

Specific details of the components needed can be found in this spreadsheet (see columns C, D, E on "Details screen section" tab and also "VA In Person - Details" tab as needed) and the design specs can be found in Figma

As part of this story we want to:

Create new components that are needed for confirmed, past, and canceled VA in-person appointment
Plug in any pre-existing components
Update end to end tests
Update headings to match Figma file
VQA with content/design

Acceptance Criteria

[ ] New components have been created
[ ] Existing components have been brought in
[ ] E2E tests have been updated
[ ] VQA by content
[ ] VQA by design

mistymg commented 7 months ago

Just a note this ticket doesn't include pending appointments. That will be it's own separate ticket.

rbontrager commented 6 months ago

@Sparowhawk A couple small issues found:

The reschedule/cancel section is no longer in its own specific section separate from the rest of the details. The figma design and the spreadsheet seems to imply it needs to be.
Less spacing between the tty link and the 'details you'd like to share with your provider' header than elsewhere in the details section.

Sparowhawk commented 6 months ago

fixed number 3

Sparowhawk commented 6 months ago

fixed number 1

rbontrager commented 6 months ago

@Sparowhawk With Misty's clarification on what past pending and past canceled appts should look like it looks like we have one tiny bug. I'm still seeing the 'cancel request' button for past pending appts. It was removed in older versions of the app and any cancel requests are removed for past upcoming appts.

Sparowhawk commented 6 months ago

removed the cancel request button

wavelaurenrussell commented 6 months ago

Let's adjust the spacing between sections so that we'll know what content goes together. Like:

Details Detail 1 Detail 2

--not--

Details

Detail 1

Detail 2

Sparowhawk commented 6 months ago

Private Zenhub Video

rbontrager commented 6 months ago

@Sparowhawk There is a couple issues caused by the new spacing:

Paragraph spacing is missing after 'We'll try to schedule you appointment in the newt 2 business days...' for upcoming pending appointments.
Paragraph spacing is missing in the 'Need to reschedule or cancel' for upcoming confirmed cancellable appointments
Spacing between TTY and 'details you'd like to share with your provider' for pending appointments is less than it is for upcoming appointments between location and 'details you'd like to share with your provider' (see pictures) Pending:

Upcoming confirmed

Sparowhawk commented 6 months ago

fixed

rbontrager commented 6 months ago

Verified that VA in person appointments match the spreadsheet and the figma design. Approved by QA.