search

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

Automation - Count number of issues detected by Accessibility check and update slack message with that value #8524

Open IsraelleHub opened 6 months ago

IsraelleHub commented 6 months ago

Automation Ticket

Type of Change

What systems/scripts are changing?

What is the work being done?

Update documentation_accessibility-checks.yml workflow to make it count number of issues detected during accessibility checks scanning. this issue is linked to [#8217](#8217: Add accessibility checks into CI for the documentation site) ticket

Testing considerations

What testing did you do?

What testing needs to be done by the reviewer?

What testing needs to be done to ensure that this work is complete in production?

Acceptability Criteria

IsraelleHub commented 4 months ago

Update: Still trying to figure out a way to have this workflow count number of accessibility issue on each url and totalize it. I was able to have the worflow count the number of url with axe issue without any problem. However, when trying to make to have the workflow count number of url instead, it just timeout out and exiting without completing. https://github.com/department-of-veterans-affairs/va-mobile-app/actions/runs/9950165478/workflow

bischoffa commented 4 months ago

@IsraelleHub can you update the ticket to include the current sprint?

IsraelleHub commented 3 months ago

Reason for Block: This task, which involves counting the number of accessibility issues for each URL, has encountered persistent timeout errors that have proven challenging to resolve. Due to the time already invested without significant progress, I've decided to deprioritize this task temporarily. I will revisit it periodically, but for now, I am shifting focus to higher-priority tasks.

lexicalninja commented 1 week ago

@IsraelleHub is there a branch you were testing this on that i could look at and maybe take a shot at?

IsraelleHub commented 1 week ago

@lexicalninja this is the4 branch chanel-8524-automation-accessibility-checks-number-issues and this is the PR. Thank you for looking into it!

lexicalninja commented 1 week ago

thank you!