department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

Componentization - Community care appointments - Detail View #8605

Closed ala-yna closed 4 months ago

ala-yna commented 6 months ago

Description

As an engineer, I want create and reuse different standardized components for appointments, so that it will easier for other teams to start working in appointments and the different appointment types can be more aligned.

Specific details of the components needed can be found in this spreadsheet (see columns F, G, H on "Details screen section" tab and also "VA Community Care - Details" tab as needed) and the design specs can be found in Figma

Note: for Community Care appointments, please be sure to use the provider location, not the associated VA facility location.

As part of this story we want to:

Acceptance Criteria

alexandec commented 5 months ago

Approval from content and design: https://adhoc.slack.com/archives/C067S0FRP0C/p1717542786392799

rbontrager commented 5 months ago

@alexandec After creating a pending CC appt in Judy and talking to Misty there was a slight change to the spreadsheet that requires some code changes. The field needed under "Details you'd like to share with your provider" needs to be changed to whatever is in the [comment] and not [reason].

alexandec commented 5 months ago

@rbontrager I've updated the AppointmentReasonAndComment component so that for for pending CC appointments only (Canceled Pending, Pending, and Past Pending), it shows the comment field instead of the reason field

alexandec commented 5 months ago

@rbontrager I figured out the issue with the cancel button. Pending appointments with no cancel ID were still showing the cancel button, but the cancel button won't work without a cancel ID. I made a change so the cancel button is hidden for pending appointments with no cancel ID. This is the same approach we take for other types of appointments. I tested with Judy on staging since she has a pending appointment with no cancel ID.

I don't know if you're able to create appointments with and without cancel IDs on staging, but that would be the ideal way to test this. Alternatively you could intercept the API response in Charles and add/remove the cancel ID to test this.

rbontrager commented 5 months ago

Everything looks good outside of the following issues:

@ala-yna Please sign off that you acknowledge these bugs and confirm you still want this ticket to be merged with them.

ala-yna commented 5 months ago

Thank you for the write up and follow up tickets. I agree with the decision to move this ticket forward knowing that there is follow up work to be done.