department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

Componentization - Video with GFE appointments - Detail View #8609

Closed ala-yna closed 5 months ago

ala-yna commented 6 months ago

Description

As an engineer, I want create and reuse different standardized components for appointments, so that it will easier for other teams to start working in appointments and the different appointment types can be more aligned.

Specific details of the components needed can be found in this spreadsheet (see columns V, W, X on "Details screen section" tab and the design specs can be found in Figma

As part of this story we want to:

Acceptance Criteria

rbontrager commented 5 months ago

@Sparowhawk Found a couple issues.

  1. Clicking on 'Add to Calender' does not bring up a calendar event for confirmed GFE appointments. Tested the same appointment on a previous build and it was working.
  2. After discussing with Lauren (originally in DM) can you add just a normal amount of space, like what we have between 'Matthew DO Everett' and 'Details you shared with your provider' not a paragraph space, between 'If you need to schedule another appointment...' and 'facility name' in the need to schedule another appointment? section.
Screenshot_20240530-071305 (1).png
Sparowhawk commented 5 months ago

fixed spacing

Sparowhawk commented 5 months ago

fixed calendar issue

rbontrager commented 5 months ago

Verified that the claim detail view follows the outline given in the spreadsheet and the design from figma. Verified that the above issues have been resolved. Approved by QA.