search

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

Migrate: merge_facilities to the appts service #8628

Closed StacyB2023 closed 4 months ago

StacyB2023 commented 5 months ago

Description

As part of our goals to consolidate and unify appts data logic between Web and Mobile Platforms, this story serves to migrate merge_facilities to the appointments service on Vets API.

Additional Info: Web & mobile's individual vets-api controllers make combined appts and facility calls to provide facility data in the appt response. We want to move this up to the service. (nice to have).

Formal Steps:

  1. Identify/Review Vets API for duplicate Code for merge_facilities

  2. Ensure unification (Data is identical)

  3. If data is not identical, address the duplicate code and ensure data is corrected.

  4. Identify what will be the common field (the field that will present and be the same on both platforms)

  5. Migrate the field identified in #4 to the appointments service on Vets API

Acceptance Criteria

- [ ] Identify an Impacts (prior to migration) - [ ] See Formal Steps above #
StacyB2023 commented 5 months ago

@jperk51 : FYI

kpethtel commented 4 months ago

This has been tested in staging. The only bug I've found was specific to the VPG feature flag, which is not used in prod. We will investigate that in a follow-up ticket.

Additionally, I've created the following two tickets for fixing very minor code issues that were created during the refactor. Those will be fixed by EOD. https://app.zenhub.com/workspaces/va-mobile-60f1a34998bc75000f2a489f/issues/gh/department-of-veterans-affairs/va-mobile-app/8853 https://app.zenhub.com/workspaces/va-mobile-60f1a34998bc75000f2a489f/issues/gh/department-of-veterans-affairs/va-mobile-app/8855