Detail view for Claims - Closed claims

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."

https://department-of-veterans-affairs.github.io/va-mobile-app/

11 stars 2 forks source link

Detail view for Claims - Closed claims #8890

Closed ala-yna closed 1 month ago

ala-yna commented 2 months ago

Description

As part of this story we want to: make changes to the detail screen for closed claims

Acceptance Criteria

[ ] Closed Claim: Show blue informational Alert (see copy doc for content inside alert)
- [ ] For digital decision letter, show Alert with primary button
- [ ] For mailed-only decision letter, show slim Alert
  - Figma mockup
[ ] Closed Claim: Show link to Large Panel:
- Link copy reads: Learn what to do if you disagree with our decision (see copy doc for Large Panel copy for content inside panel)
[ ] Ensure style alignment with Figma mockup
[ ] VQA with Lauren / Misty

Notes & Open Questions

rbontrager commented 1 month ago

@Sparowhawk Detox is broken for the Claims e2e (run can be found here).

Sparowhawk commented 1 month ago

@rbontrager Detox fixed https://github.com/department-of-veterans-affairs/va-mobile-app/actions/runs/10014139392/job/27683259510

rbontrager commented 1 month ago

@Sparowhawk It's fixed for iOS but is still failing for Android. Looking at the failure it looks like you need to add atIndex(0) to the following lines in the 'verify what should I do if disagreement information'. Its due to a detox quirk with Android.

await element(by.id('Learn what to do if you disagree with our decision')).atIndex(0).tap()
await expect(element(by.text('Learn what to do if you disagree with our decision')).atIndex(0)).toExist()

You will also need to add 'await element(by.id(ClaimsE2eIdConstants.CLAIMS_DETAILS_SCREEN_ID)).scrollTo('top') to the first line in the 'verify details tab infomation' test because for android it scrolls down in the test before.

Sparowhawk commented 1 month ago

@rbontrager Thank you for that bit of help. i made those changes

rbontrager commented 1 month ago

Verified that if a decision letter is available an alert appears (matching the figma design) that allows the user to click on it to view their decision letter. Verified that if a decision letter is not available an alert appears without a button stating the decision letter was mailed. Verified that there is a 'Learn what to do if you disagree with our decision' link to a large panel for closed claims. Verified that the smoke a11y tests passed as well as the detox tests. Approved by QA.