search

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
12 stars 2 forks source link

compare prod user output between current mobile military information and lighthouse military service api #9036

Closed aherzberg closed 1 month ago

aherzberg commented 1 month ago

As a continuation of https://app.zenhub.com/workspaces/va-mobile-60f1a34998bc75000f2a489f/issues/gh/department-of-veterans-affairs/va-mobile-app/8984. the lighthouse api may have more accurate results for military service discharge codes. Compare the logs to verify this.

aherzberg commented 1 month ago

Working on getting LH help to test out endpoints https://dsva.slack.com/archives/C02CQP3RFFX/p1720807030520829

aherzberg commented 2 weeks ago

After a meeting with LH, the LH status endpoint is going to end up being more accurate. We just check service history rn but the LH status endpoint is going to make a change in a month or so that will check both service history, the nature of that history, and if they have a service connected disability (if they have that, it doesn't matter what the other values are, they are considered a veteran). This should see a slight increase in confirmation of status but nothing like the huge increase we saw with that test data. that test data was using just MPI data which apparently isn't as accurate.

So next steps is we wait for that update to be live and just integrate vets-api with that endpoint and run the data ourselves to compare again and make the call based on that.