BUG - sev-2 - Android - LinkWithAnalytics-related crashes

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."

https://department-of-veterans-affairs.github.io/va-mobile-app/

13 stars 2 forks source link

BUG - sev-2 - Android - LinkWithAnalytics-related crashes #9064

Open bischoffa opened 2 months ago

bischoffa commented 2 months ago

Current Status 2024-07-19: Crash is affecting ~2500 users daily. It's limited to Android 14 with 95% of crashes on the payment history screen. The crash is intermittent. Mobile engineers are working to reproduce and diagnose it.

Description: Email received by VAHB Mobile team from Google Play Console of anomalies detected regarding user-perceived crash rate.

Notes:

ACs:

bischoffa commented 2 months ago

TKDickson commented 2 months ago

More helpful information appearing in the latest firebase crash reports are helping narrow this down - appears to be the LinkWithAnalytics component (definitely on the PaymentHistory screen, although I bet other screens including direct deposit are also impacted given those screens were included in the earlier/less helpful crash reports).

The Google Analytics changeover (from whatever the heck to G4A/GA4/whatever that new thing is) was right around July 1st, when we first started seeing these.

This is enough information to move into a ready-to-work state; will include in global grooming tomorrow.

timwright12 commented 2 months ago

@TKDickson thank you! @ajsarkar28 @dumathane please prioritize this work as the crash has been happening for longer than we're comfortable.

TKDickson commented 2 months ago

Link to FE thread where a lot of discussion has happened (again)

timwright12 commented 2 months ago

Relevant user feedback

Group 3

timwright12 commented 2 months ago

group_2_720

Ideas:

replace linkwithanalitics with a normal link
debug re-rendering issue by added console log in each rendered hook or something that updates the UI to see if there's a weird loop

TKDickson commented 2 months ago

Adding some notes from Binny and I's session trying to hunt this down today (some of these were noted elsewhere as well, already, but):

This is just Android (not iOS)
This is happening intermittently (the most impacted page, for instance, is Payment History - but there are plenty of people also ABLE to access Payment History without a crash, on 2.31)
Binny may have reproduced it on his emulator, with his production account (saw a crash on the no RX page), but was unable to reproduce after logging back in
There are crash reports on multiple pages. The vast majority (I want to say 90-95%) payment history. Disability Ratings, and Direct Deposit, tie for a very distant second place. There are also a non-zero number of crashes for "Prescription History No Prescriptions", Contact VA, NotEnrolledSM, and "Cerner Alert, Category Landing, Health Screen".
Therese still has been unable to reproduce with demo mode on PROD, or staging users. Because this is intermittent, it's unclear whether this is because it's not possible to produce the crash under those circumstances, or we just haven't seen it there.

TKDickson commented 1 month ago

We're trying to get a fix for #9065 into this sprint (plus some other code cleanup that Theo found in there), in the hopes it'll reduce the incidences of this crash. Still unable to reproduce internally, nor have we found a definitive cause.

timwright12 commented 1 month ago

We're still seeing this crash reported in 2.34.0

timwright12 commented 1 month ago

@dumathane @ajsarkar28 Any updates on this? We're still seeing elevated crashes on Android. Is it time to think about removing the component in these places until we can fix it?

bischoffa commented 1 month ago

Binny mentioned this was reviewed during yesterday's FE sync and Narin would take a look at it, so I have assigned it to Narin.

dumathane commented 1 month ago

Theo did some work on ticket #9065 we were hoping would reduce or eliminate this issue. That work wasn't slated to be delivered until this next coming Tuesday but instead was mistakenly sent out to the android app store early this last Tuesday the 6th. Tim reports we are still seeing the crash in 2.34 so it didn't eliminate the crashing entirely. After discussing at FE Sync yesterday @narin is taking a look to see if he can try to help us identify anything else we could do with his technical expertise.

timwright12 commented 1 month ago

@dumathane It looks like our linkwithanalytics crash reports for 2.34.0 got combined with the the crash reports for the claims issue that popped up last week. Seeing that the crashes starting on 8/9 shot way down near zero (after the claims issue was fixed) I'm comfortable closing this ticket out with the assumption that #9065 may have fixed it. I can keep an eye open this week to see if it occurs again and re-open if @TKDickson is OK with that plan.

TKDickson commented 1 month ago

@dumathane @timwright12 yep, that's fine by me.

TKDickson commented 1 week ago

Reopening this issue, because something about 2.36 seems to have re-introduced it.

timwright12 commented 1 week ago

About 1600 crashes for this in the past two days: Firebase Crash report

TKDickson commented 1 day ago

The FE team's plan for this is to see if the RN update impacts the crash. Can ask @dumathane for further details.