search

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

Change appeals access policy #9114

Open kpethtel opened 3 months ago

kpethtel commented 3 months ago

As described here, the appeals policy does not provide a good user experience. Investigate which policy we should use and change accordingly. This ticket may also provide insight into which policy we should use.

ACs:

kpethtel commented 2 months ago

@jperk51 requested that i summarize my concerns about this ticket here. In summary, I think we need to consider the pros and cons of using enrollment status as part of our access policy.

Fetching enrollment status on every authorized services request will add an additional dependency to the endpoint as well as some additional latency. This is acceptable if it's necessary, but it's also not ideal because the large majority of users are likely enrolled and will continue to be enrolled. So to check on their enrollment status every session will result in a large number of unnecessary requests, which will put additional strain on the vets-api and upstream servers.

It may be better to determine how often we need to re-check enrollment for enrolled veterans as well as caching strategies. If we decide that long-term caching is needed, we can create a DB record in the vets-api. If we want to re-check occasionally, we could cache in the frontend.

jperk51 commented 2 months ago

Having a meeting tomorrow with FE and QA to decide what option we want to go through with

jperk51 commented 2 months ago

Backend is going to proceed with a larger effort to improve all authorization policies in vets-api that we use. @StacyB2023 let's get together to make an epic for this

StacyB2023 commented 2 months ago

New Epic: https://app.zenhub.com/workspaces/va-mobile-60f1a34998bc75000f2a489f/issues/gh/department-of-veterans-affairs/va-mobile-app/9409 cc: @jperk51

TKDickson commented 1 month ago

Hey @jperk51 @StacyB2023 - what's the blocker on this ticket? Or is it unblocked? cc @dumathane

aherzberg commented 3 weeks ago

Setting as blocked as I have been unable to get a response from any upstream teams on if using enrollment status is a correct metric to block appeals access. @DonMcCaugheyUSDS let me know when you have some time jump into these convos.