department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
12 stars 2 forks source link

BUG - sev-3 - All - Failed HSP-related API calls are called again during logout #9173

Closed TKDickson closed 1 month ago

TKDickson commented 1 month ago

What happened?

Any HSP-related functionality API calls that fail, are being called again during explicit logout (I tap the 'sign out' button and confirm I want to log out, from the Settings screen).

For example - karsyn (who'll get the typical 502 for claims/appeals) will get the claims and appeals overview API called again if he logs out.

If you edit his authorized-services to allow disability rating and lettersanddocuments (so those APIs will get called, but of course fail because he isn't actually authorized for them in upstream systems), then those APIs, plus claims/appeals, will get called again during logout. And so on.

Specs:

Steps to Reproduce

Desired behavior

Should not be calling login-needed APIs during logout, regardless if they passed or failed when called during login.

Acceptance Criteria

Bug Severity - BE SURE TO ADD THE SEVERITY LABEL

See [Bug Tracking](https://department-of-veterans-affairs.github.io/va-mobile-app/docs/QA#issue-severity) for details on severity levels

Linked to Story

Screen shot(s) and additional information

Full JSON response for services related to issue (expand/collapse)

Ticket Checklist

TKDickson commented 1 month ago

Blech; zenhub bug that caused this to be created twice. I'll use #9174 as the real version of this. Removing labels & closing.