search

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

Automation - Run Detox tests for Dependabot PRs #9392

Open theodur opened 2 months ago

theodur commented 2 months ago

Automation Ticket

Type of Change

What systems/scripts are changing?

What is the work being done?

Dependabot PRs don't have Detox tests run on them anymore due to recent logic changes:

The e2e_ios and e2e_android workflows should be updated to run the full suite of Detox tests on Dependabot PRs. Specifically, the logic in the find_detox_tests_to_run and output_detox_tests_to_run jobs need to be updated.

Testing considerations

What testing did you do?

The logic should be tested on an existing Dependabot PR.

What testing needs to be done by the reviewer?

Verify the logic in the workflows are updated to include Dependabot PRs.

What testing needs to be done to ensure that this work is complete in production?

N/A

Acceptability Criteria

theodur commented 5 days ago

I just merged the latest changes from develop, and noticed Dependabot PRs still aren't running Detox tests.

Example PR: https://github.com/department-of-veterans-affairs/va-mobile-app/pull/10048 Example workflow run: https://github.com/department-of-veterans-affairs/va-mobile-app/actions/runs/11710146054