CU - Change many components out of 'link' and 'button' roles

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."

https://department-of-veterans-affairs.github.io/va-mobile-app/

17 stars 2 forks source link

CU - Change many components out of 'link' and 'button' roles #9464

Closed TKDickson closed 2 weeks ago

TKDickson commented 3 months ago

Proposed Change

In response to #9288 (in order to stop the worst impacts), we changed the role for several components to either 'button' or 'link'. Some of them can stay that way (bottom navigation bar, menu list items) but all of the remaining changes should eventually be changed back to a role that 1) is correct and 2) continues to work with all assistive tech.

This could be in response to a fix from iOS or React Native, or could be if we find a working medium-term solution with #9463.

Why Should We Prioritize?

Coding Time Estimation

Testing Considerations

Checklist

[x] Add the relevant team label (Health, global, design system, API, Qa and Release etc.)
[ ] Attach to ticket to the relevant Team Tech Debt Epic epic (old frontend engineering epic is no longer in use as each team is managing their code's technical debt and code upkeep work)

alexandec commented 2 months ago

As described in #9474, the relevant keyboard navigation issue was fixed by Apple in iOS 18 as of 9/16/24. Once enough of our users have upgraded to iOS 18, we can implement the changes described in this ticket.

I've created a branch called revert-keyboard-nav-workarounds that mostly reverts the changes as desired. However the bottom navigation bar and menu list item changes should not be reverted, so a couple tweaks to the branch will be required.

alexandec commented 2 months ago

Removing #9463 as a blocker since Apple fixed the issue.

TKDickson commented 2 months ago

This is global work & will build off of Chris's existing investigation, but we'll be the ones doing it; removing his assignment & the health label - FYI @ala-yna

rbontrager commented 1 month ago

@cadibemma VoiceOver is not saying the role for any of the changes you made on iOS. So for example:

Segmented controls (using claims history active/closed): Saying "Active 1 of 2. Review you..." its saying "Active 1 of 2. tab. Review your..."
Radio button (using gender identity): "Man" instead of "Man radio button"
VAModalPicker (payments): "Select a year picker. Filled 2017" instead of "Select a year picker. Filled 2017 spin button"

dumathane commented 3 weeks ago

@rbontrager CC: @cadibemma ,

Rachael, do you know/can you test if this was working on a previous ios and is now broken in 18? Do you have some older ones we could load Chika's branch on?

Thanks, let us know.

rbontrager commented 2 weeks ago

Determined that the above issue was actually an issue before 9288 and out of scope. Made bug ticket 10185 to address it. Otherwise verified over voiceOver that segmentedControls, VAModelPickers, and Radio groups correctly read out as tab, spinbutton, and radio roles for android respectively and still function as intended. Approved by QA.