search

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
15 stars 2 forks source link

cu: Update fornts webviewTitle and textWithIconButton to min 16 #9723

Open juancstlm-a6 opened 2 days ago

juancstlm-a6 commented 2 days ago

Description of Change

Update webviewTitle and textWithIconButton font sizes to be a minimum of 16. webviewTitle variant was unused and very small so it was updated to match the default MobileBody sizing Update <WebViewTitle /> component to use variant="webviewTitle" explicitly and keep the original sizing.

Screenshots/Video

iOS | Before | After | | ---- | ---- | | iphone_standard_before_webviewTitle | iphone_standard_after_webviewTitle | | iphone_standard_before_textWithIconButton | iphone_standard_after_textWithIconButton | | Screenshot 2024-09-26 at 1 23 42 PM | iphone_mini_after_textWithiconButton | | Screenshot 2024-09-26 at 1 24 33 PM | iphone_mini_after_webTitle |
Android | Before | After | | --- | --- | |Screenshot 2024-09-26 at 12 33 57 PM|Screenshot 2024-09-26 at 12 11 23 PM| | Screenshot 2024-09-26 at 12 33 37 PM | Screenshot 2024-09-26 at 12 18 45 PM | |Screenshot 2024-09-26 at 12 30 41 PM|Screenshot 2024-09-26 at 12 19 40 PM| |Screenshot 2024-09-26 at 12 30 22 PM|Screenshot 2024-09-26 at 12 12 29 PM|
- [X] Tested on iOS - [X] Tested on Android ## Reviewer Validations Tab View icon label is now a minimum of 16 WebView title is now a minimum of 16 ## PR Checklist **Reviewer:** Confirm the items below as you review - [x] PR is connected to issue(s) - [x] Tests are included to cover this change (when possible) - [X] No magic strings (All string unions follow the [Union -> Constant](https://github.com/department-of-veterans-affairs/va-mobile-app/blob/develop/VAMobile/src/constants/common.ts) type pattern) - [X] No secrets or API keys are checked in ~~- [ ] All imports are absolute (no relative imports)~~ ~~- [ ] New functions and Redux work have proper TSDoc annotations~~ ## For QA [Run a build for this branch](https://github.com/department-of-veterans-affairs/va-mobile-app/actions/workflows/on_demand_build.yml)