department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
0 stars 0 forks source link

Link component - Add Attachment type support #183

Closed TimRoe closed 4 months ago

TimRoe commented 4 months ago

Description

Initially ticket #118 determined Attachment links to lack nuance worthy of incorporation into the component until that was in PR. Subsequently it was recognized that actually we can provide more meaningful support for attachments and this ticket is to do so.

Update: some content of this ticket was split to #184 as post-MVP enhancement.

Acceptance Criteria

Note: See AttachmentLink flagship component for behavior to emulate/improve - [x] Add new type `attachment` to Link component w/ type specific data of: - `onPress` (required) for opening attachment logic, an inherently app-level function as the component doesn't know how it's stored - [x] Add new LinkProps prop `a11yValue` (optional) that allows sending an accessibilityValue for when links are part of a list - [x] `attachment` should default in the PaperClip icon - [x] Added 2/29: Remove support for inline Link **Accessibility Requirements** Indicated in ACs above as well. - [x] Add support for a11yValue for links in lists