search

department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
0 stars 0 forks source link

BUG - Sev 3 - Web - On press bolding does not work for Inline variant #197

Closed TimRoe closed 2 months ago

TimRoe commented 4 months ago

What happened?

When building the Link component Inline variant (#168), it was noted that the on press bolding does not work in Web Storybook. It works fine in iOS/Android. As Web is not an officially supported platform, this was deemed fine to separate.

Steps to Reproduce

  1. Navigate to the Directions Link variant in the mobile design system storybook
  2. Press and hold on the link
  3. Note: It bolds the text while held
  4. Navigate to the Inline Link variant
  5. Press and hold one of the links
  6. Note: It does not bold

Desired behavior

Should bold on pressing like in iOS/Android.

Acceptance Criteria

Bug Severity - BE SURE TO ADD THE SEVERITY LABEL

See [Bug Tracking](https://department-of-veterans-affairs.github.io/va-mobile-app/docs/QA#issue-severity) for details on severity levels

Web Storybook for demonstration purposes, not officially supported to function flawlessly.

Linked to Story

Noted during #168

Screen shot(s) and additional information

Technically, the Inline variant uses React Native Text component instead of Pressable to wrap correctly so the links within Inline are built in a special way--this is likely the culprit. A fix to this bug may lie within the react-native-web package instead of any code we control based on it working in iOS/Android with the same code.

bischoffa commented 2 months ago

adding severity label to this ticket

bischoffa commented 2 months ago

Unable to add severity label to this ticket. @TimRoe can you please add it

TimRoe commented 2 months ago

I'll do you one better and close it entirely as on press bolding was determined to not be desired (after determining it was a miscommunication with VADS) and was replaced with on press background highlight. Also the inline Link variant no longer exists for now so it doubly doesn't exist.

Similar problem may occur with on press behavior of inline Links when it returns, but that may be quite some time and we can cross that bridge when we come to it again if it is problematic.