I noticed a couple issues with the icon alignment in the Link component.
[x] Currently, the icon SVG is not vertically or horizontally centered within the 24x24 icon container.I checked the icon SVGs and they don't appear to be the issue. I think the Link component needs to be updated to center the icons in the container.
Will be addressed with bug ticket #100
[x] Currently, the icon container is vertically centered when the text spans multiple lines. Instead, the icon should be fixed in the top left corner. The line height of the first line of text is 30 and the icon should be vertically centered within that area.
Current appearance
Correct appearance
[x] Update target size to 44px
[x] I also noticed an issue with the "You're leaving the app" alert. In the Directions link, the alert is not currently using the updated copy that Misty provided. This should be updated to use the same copy.
Only displaying in Storybook for testing purposes.
[x] I also noticed something unique about the Directions link. Currently, the screenreader seems to read "[link text] link" for every link variant. For example, "Add to calendar link". For the Directions link, there's some additional text and it reads "Get directions with maps app link. Opens maps app with directions to location." Was that intentional? Is there a reason the Directions link reads the additional text?
Only displaying in Storybook for testing purposes.
Also, I'd like to note that I created a ticket in the post-MVP epic to refine the action sheets for phone and TTY. I think the text and icon could be updated there, but that's a very low priority thing that can wait until later.
I noticed a couple issues with the icon alignment in the Link component.
Currently, the icon SVG is not vertically or horizontally centered within the 24x24 icon container.I checked the icon SVGs and they don't appear to be the issue. I think the Link component needs to be updated to center the icons in the container.I also noticed an issue with the "You're leaving the app" alert. In the Directions link, the alert is not currently using the updated copy that Misty provided. This should be updated to use the same copy.I also noticed something unique about the Directions link. Currently, the screenreader seems to read "[link text] link" for every link variant. For example, "Add to calendar link". For the Directions link, there's some additional text and it reads "Get directions with maps app link. Opens maps app with directions to location." Was that intentional? Is there a reason the Directions link reads the additional text?Also, I'd like to note that I created a ticket in the post-MVP epic to refine the action sheets for phone and TTY. I think the text and icon could be updated there, but that's a very low priority thing that can wait until later.