department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
1 stars 0 forks source link

DS - Publish should depend on components integration passing #230

Open narin opened 6 months ago

narin commented 6 months ago

Description

There is currently no restriction on publishing if the component integrations workflow fails. This workflow clones the mobile app, adds the current branch of mobile components as a dependency, and runs tsc:compile. We should not be publishing if this command fails.

Acceptance Criteria

- [ ] `check-components` workflow steps have been copied to `publish` workflow and should fail if `tsc:compile` fails OR - [ ] `check-components` has been refactored to be able to run as [a shared workflow](https://docs.github.com/en/actions/using-workflows/reusing-workflows) and been added as a step in our `publish` workflow OR - [ ] Check if last run of `check-components` passed on `main` before allowing publish, possibly with override flag