[Bug] Fix horizontal alignment

[narin]

Description of Change

This PR serves as a minor bug fix ticket as well as the validation for the Link. Tested the Link component in the app by replacing some phone, tty, attachment and links in Secure Messaging.

Noticed that if a Link does not have a Box surrounding it, it will be horizontally centered. Removing the justifyContent: center in this PR aligns the Link left while maintaining other styling. Also noticed that the icon is not vertically aligned at larger text sizes but since that is a more complex fix, created ticket https://github.com/department-of-veterans-affairs/va-mobile-library/issues/240 to address it separately.

Tested iOS Voiceover and Android talkback on links and verified that a11y labels and a11y hints are identical. iOS screen recordings attached below. Android screen recording did not include the voicings.

Testing Packages

• 0.11.1-alpha.0
• 0.11.1-alpha.1
• 0.11.1-alpha.3

Screenshots/Video

Alignment fix

Before

After

Testing

External Link functionality

https://github.com/department-of-veterans-affairs/va-mobile-library/assets/786704/85710da1-845d-4c4c-b49e-c5700591c982

Attachment Link functionality

https://github.com/department-of-veterans-affairs/va-mobile-library/assets/786704/2440c853-62b7-490b-ace5-4733809011fb

External Link iOS Voiceover

https://github.com/department-of-veterans-affairs/va-mobile-library/assets/786704/62e35193-867a-4a81-bfd4-036a2bc026bf

Attachment Link iOS Voiceover

https://github.com/department-of-veterans-affairs/va-mobile-library/assets/786704/c4b8695e-2441-4435-b23e-4e9ca1706e47

Secure Messaging

https://github.com/department-of-veterans-affairs/va-mobile-library/assets/786704/816ead2d-44da-4331-8ef3-cdcd80e16a6c

Testing

• [x] Tested on iOS
• [x] Tested on Android
• [x] Tested on Web

PR Checklist

Code reviewer validation:

• General
  • [x] PR is linked to ticket(s)
  • [x] PR has changelog label applied if it's to be included in the changelog
  • [x] Acceptance criteria:
    • All satisfied or
    • Documented reason for not being performed or
    • Split to separate ticket and ticket is linked by relevant AC(s)
  • [x] Above PR sections adequately filled out
  • [x] If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
• Code
  • [x] Tests are included if appropriate (or split to separate ticket)
  • [x] New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

• [x] Merge main into branch
• [x] Merge branch to main
• [ ] Publish new version after merging

[TimRoe]

Audio isn't working for the "Secure Messaging" video on Android--for whatever reason Android doesn't record the screen reader, need to select the option with microphone on and it picks it up that way (or maybe there's some other setting to fix it).

Edit: Ah, nvm the write-up mentioned it "Android screen recording did not include the voicings."

Also, is that preexisting that the hyperlinks are so poorly vertically aligned with the rest of the text in secure messaging?

Looking back at a Slack thread discussing it doesn't look that misaligned:

[narin]

@TimRoe I had a combination of both the old links and the new Link components mixed in to test them side by side which I think was causing that. Stripped out the old links and vertical alignment looks pretty close to it was: