department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
0 stars 0 forks source link

BUG - Sev-3 - All - Link Icon is not vertically aligned at larger text sizes #240

Closed narin closed 2 months ago

narin commented 3 months ago

What happened?

When zoomed in, Icons to the left of Links are not vertically aligned with the first line

Addition: Depending on when this is worked, a similar solution will also be needed on the Alert component which expects similar icon behavior and is initially copying Link's method.

Specs:

Steps to Reproduce

  1. Increase OS text size to largest size
  2. View a Link with an Icon

Desired behavior

Icon should be vertically centered and aligned with first line of text

Acceptance Criteria

Bug Severity - BE SURE TO ADD THE SEVERITY LABEL

See [Bug Tracking](https://department-of-veterans-affairs.github.io/va-mobile-app/docs/QA#issue-severity) for details on severity levels

Linked to Story

Screen shot(s) and additional information

image.png
Full JSON response for services related to issue (expand/collapse)

Ticket Checklist

TimRoe commented 3 months ago

Updated bug slightly to include:

Addition: Depending on when this is worked, a similar solution will also be needed on the Alert component which expects similar icon behavior and is initially copying Link's method.

TimRoe commented 2 months ago

Adding more extreme example of this bug (and added an AC for validation case) from flagship's implementation where they prevent scaling on the icon and it looks much worse with large font size: image