[Feature] Replace service emblems and VA SVGs with png. Add Space Force emblems.

[narin]

Description of Change

Replaces VA logo and service emblem SVGs with PNGs. Add Space Force emblems and VA logo with dark text.

Testing Packages

N/A

Screenshots/Video

N/A (See images in Files changed)

Testing

N/A

PR Checklist

Code reviewer validation:

• General
  • [x] PR is linked to ticket(s)
  • [x] PR has changelog label applied if it's to be included in the changelog
  • [x] Acceptance criteria:
    • All satisfied or
    • Documented reason for not being performed or
    • Split to separate ticket and ticket is linked by relevant AC(s)
  • [x] Above PR sections adequately filled out
  • [x] If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
• Code
  • [x] Tests are included if appropriate (or split to separate ticket)
  • [x] New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

• [ ] Merge main into branch
• [ ] Merge branch to main
• [ ] Verify that Check Component Integrations workflow ran successfully
• [ ] Publish new version after merging

[jessicawoodin]

@narin and I discussed the issues and are leaning towards using the same files that VADS uses. For some reason, the app currently uses different emblems than VADS, and I’d prefer to be cautious and use the same emblems as VADS, even if it results in lower quality graphics. Currently, the files that are used in the app are not scaling properly when converted to PNG and exported at various sizes. By using the VADS PNGs, we’ll no longer have the scaling issues. I’m going to continue to think through this and will follow up with the files tomorrow.

[TimRoe]

For some reason, the app currently uses different emblems than VADS

The reason is because a React Native update broke using the PNG-as-SVG method being used for the service emblems, it had already been merged to develop, and backing out such a change would've been a big pain so SVG versions were found and swapped in in short order and ticket 5878 created to get actually good SVGs (which never happened because military branches were uncooperative). It was only much later realized that the VA Logo was still using PNG-as-SVG so maybe they could've been adjusted to continue working.

Currently, the files that are used in the app are not scaling properly when converted to PNG and exported at various sizes.

Not sure I follow this--since they're SVGs, they should scale fine (and looking at them in storybook seem to) and the PNGs in this ticket don't appear to be the SVGs currently in use.

Edit: Or I guess most of them could be the same with scaling screwed up--seems like that doesn't add up for the Marines/Navy though.

[jessicawoodin]

Going forward, the mobile library should provide the same emblems that VADS provides. I updated the Emblems.zip file in the ticket. The zip file also includes the two new Space Force logos. I will let VADS know about the two additional logos and also see if they might have higher quality files for all emblems.

[TimRoe]

Going forward, the mobile library should provide the same emblems that VADS provides. I updated the Emblems.zip file in the ticket. The zip file also includes the two new Space Force logos. I will let VADS know about the two additional logos and also see if they might have higher quality files for all emblems.

For clarity, VADS currently doesn't have the emblems at all. They are part of the VA.gov repo.

There is an outstanding ticket for VADS to incorporate them separately. Potentially that ticket could also serve for tracking getting higher quality versions (potentially SVGs of all reasonable files sizes that can scale without any issues for website, mobile, whatever).