Updated assets package to 0.9.0 that includes all VADS icons and removes redundant mobile specific icons
Created a new components package script to automatically process the assets package icons into a new file (iconList.ts) that handles import logic + creates IconMap object for icons
Updated README to reflect new script
Updated Icon component
Removed import statements and IconMap object
Imports IconMap from script-created file
Removed fill2 and stroke props as no longer relevant with the new icons
Cleaned up associated outdated doc
Cleaned up .svgrrc file as single path SVGs appear to work to set fill without them
Updated unit tests/stories as needed
Updated Alert component
New icons for warning/error variants
Updated icons (same name) for info/success variants
New icons for expand/collapsed state indication
Checked with Jessica that expand/collapse icons were now too small then adjusted default size to 24x24 (up from 16x16)
Since default icon sizing is 24x24, removed all height/width/maxWidth and added preventScaling instead
Cleaned up prior workaround for consistent right body padding on expandable version
While updating, noted we were redundantly setting the icon fill colors and cleaned that up
Updated unit tests to reflect changes
Updated Link component
New icons for 4 variants (attachment, calendar, text, url)
Updated icons (same name) for remaining variants
Updated unit tests/stories as needed
Shifted custom icon for unit tests/stories from my previous favorite icon Truck (no equivalent until our requested additions to VADS percolate through) to CleanHands, my new favorite icon
Updated our repo node version from >=18 to >=20 as part of the icon script uses an option (recursive) added with node 20 which greatly simplifies the logic
Testing
Validated all icons in Web appear as expected. One bug noted with the Home vs. HomeOutlined having slightly inconsistent door size, but not sure if we should delay the ticket for (added to Slack thread asking Jessica). Spot checked a handful of random iOS/Android icons looked good. Validated light/dark mode and various ways of setting icon colors ("default", "base", custom light/dark object, custom fixed color ("red"), custom hex colors) still work. Validated resizing works as expected still.
Validated Alert and Link component appear as expected with updated icons. Validated the simplification of Alert logic behaved as expected.
[x] Tested on iOS
[x] Tested on Android
[x] Tested on Web
PR Checklist
Code reviewer validation:
General
[x] PR is linked to ticket(s)
[x] PR has changelog label applied if it's to be included in the changelog
[x] Acceptance criteria:
All satisfied or
Documented reason for not being performed or
Split to separate ticket and ticket is linked by relevant AC(s)
[x] Above PR sections adequately filled out
[x] If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
Code
[x] Tests are included if appropriate (or split to separate ticket)
Description of Change
assets
package to 0.9.0 that includes all VADS icons and removes redundant mobile specific iconscomponents
package script to automatically process theassets
package icons into a new file (iconList.ts
) that handles import logic + creates IconMap object for iconsfill2
andstroke
props as no longer relevant with the new icons.svgrrc
file as single path SVGs appear to work to set fill without themheight
/width
/maxWidth
and addedpreventScaling
insteadTruck
(no equivalent until our requested additions to VADS percolate through) toCleanHands
, my new favorite icon>=18
to>=20
as part of the icon script uses an option (recursive) added with node 20 which greatly simplifies the logicTesting
Validated all icons in Web appear as expected. One bug noted with the Home vs. HomeOutlined having slightly inconsistent door size, but not sure if we should delay the ticket for (added to Slack thread asking Jessica). Spot checked a handful of random iOS/Android icons looked good. Validated light/dark mode and various ways of setting icon colors ("default", "base", custom light/dark object, custom fixed color ("red"), custom hex colors) still work. Validated resizing works as expected still.
Validated Alert and Link component appear as expected with updated icons. Validated the simplification of Alert logic behaved as expected.
PR Checklist
Code reviewer validation:
changelog
label applied if it's to be included in the changelogPublish
If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:
main
into branchmain