department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
0 stars 0 forks source link

[Enhancement] Update Icon component with VADS icons #334

Closed TimRoe closed 3 weeks ago

TimRoe commented 1 month ago

Description of Change

Testing

Validated all icons in Web appear as expected. One bug noted with the Home vs. HomeOutlined having slightly inconsistent door size, but not sure if we should delay the ticket for (added to Slack thread asking Jessica). Spot checked a handful of random iOS/Android icons looked good. Validated light/dark mode and various ways of setting icon colors ("default", "base", custom light/dark object, custom fixed color ("red"), custom hex colors) still work. Validated resizing works as expected still.

Validated Alert and Link component appear as expected with updated icons. Validated the simplification of Alert logic behaved as expected.

PR Checklist

Code reviewer validation:

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge: