department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
0 stars 0 forks source link

[Enhancement] Adjust viewBox for icons extracted from SVG sprite #336

Closed narin closed 1 month ago

narin commented 1 month ago

Description of Change

The default viewBox of 0 0 24 24 has too much whitespace around the icons, making them appear almost 20% smaller than required at 42x42 instead of 50x50. The updates the extraction script to replace the viewBox of each svg with 2 2 20 20 which gets us closer to the desired size.

Testing Packages

Screenshots/Video

Testing

PR Checklist

Code reviewer validation:

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

narin commented 1 month ago

No longer needed as default viewBox was decided to be ideal