department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
0 stars 0 forks source link

[Feature] Update component-library and extract new icons #355

Closed narin closed 4 days ago

narin commented 1 week ago

Description of Change

There will be a follow up ticket to update the Icon component/types after a new release of the assets package has been published.

Testing Packages

N/A

Screenshots/Video

N/A

Testing

PR Checklist

Code reviewer validation:

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

narin commented 4 days ago

Fixed icons. These new icons have a viewBox of 0 -960 960 960. I had changed them to 0 0 24 24 to match the existing icons but that's what seemed to have throw them off. Not sure why the viewBox is different, but after reverting to 0 -960 960 960 they are displaying and scaling properly when testing in Storybook web and iOS as well.

FYI, there is a duplicate shipping icon. I will notify VADS about this to remove one of them.

narin commented 4 days ago

VADS is already aware of the duplicate local shipping icon and is planning to remove it in the next round of icon updates.