Added 8 new Icon unit tests around the fill property testing:
4 categories:
Single string (does not change with light/dark mode)
"default" colors
"base" colors
Custom light/dark mode color object
Light/dark mode for each
Made minor adjustments to existing tests to simplify and/or improve them.
Testing
yarn tests passes with all new Icon tests. Draft tested different expect values caused failures as expected.
PR Checklist
Code reviewer validation:
General
[x] PR is linked to ticket(s)
[x] PR has changelog label applied if it's to be included in the changelog
[x] Acceptance criteria:
All satisfied or
Documented reason for not being performed or
Split to separate ticket and ticket is linked by relevant AC(s)
[x] Above PR sections adequately filled out
[x] If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
Code
[x] Tests are included if appropriate (or split to separate ticket)
Description of Change
Added 8 new Icon unit tests around the
fillproperty testing:Made minor adjustments to existing tests to simplify and/or improve them.
Testing
yarn testspasses with all new Icon tests. Draft tested differentexpectvalues caused failures as expected.PR Checklist
Code reviewer validation:
changeloglabel applied if it's to be included in the changelogPublish
Changes do not warrant a new version per the versioning guidelines as they are purely unit tests.