department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
1 stars 0 forks source link

DS - Typography Tokens - SPIKE - Components vs. Tokens #496

Open kellylein opened 1 week ago

kellylein commented 1 week ago

Description

As part of this story, we want to:

Design Notes

image.png

Acceptance Criteria

Ticket Checklist

narin commented 3 hours ago

Tokens only (No Components)

Developers use RN’s built in Text component, but can use our preset typography tokens in the component’s style prop

Example Code:

import { Text } from 'react-native'

import { typography } from '@department-of-veterans-affairs/mobile-tokens'
...

const textStyle = {
  ...typography.headingLg,
  color: theme.vadsColorForegroundDefault
}

return (
  <Text style={textStyle}>{text}</Text>
)

Pros

Cons

Single component

Example Code:

import { Text } from '@department-of-veterans-affairs/mobile-component-library'
...

return (
  <Text variant="body" size="lg">{text}</Text>
)

Provide a single Text component (name TBD) that has preset variants for each typography variant

Pros

Cons

Separate components

Provide 4 components (e.g. HeadingText, BodyText, DisplayText, NavigationText)

Example Code:


import { BodyText } from '@department-of-veterans-affairs/mobile-component-library'
..

return (
  <BodyText size="lg">{text}</Text>
)

Pros

Cons