department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
1 stars 0 forks source link

[Feature] Add composite typography tokens #572

Closed narin closed 2 weeks ago

narin commented 4 weeks ago

Description of Change

This PR creates a new composite.json file which contains composite tokens made up from our font family, line height, paragraph spacing, and letter spacing tokens.

Check npm for sample output

Testing Packages

Screenshots/Video

N/A

Testing

Tested by importing into components package.

PR Checklist

Code reviewer validation:

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

narin commented 3 weeks ago

@jessicawoodin Could you please review composite.json to check the values for accuracy? Thanks.

narin commented 3 weeks ago

Ready for second review. @jessicawoodin if you could please take a look at the updated typography.json to double check the updated marginBottom values that'd be great.

Created separate ticket to look into combining figma export into single file: #577

TimRoe commented 3 weeks ago

Was there some further discussion I missed? If not, I think this ticket is a bit off. The font file for figma is already one file, it's just not grouped so things don't parse out into style/size/etc. in Figma as desired. This is the first I'm hearing of any desire to roll spacing/colors/font into a single file.

Had some discussion with @jessicawoodin but may have misinterpreted the desired outcome. Will clarify in stand-up.