Closed narin closed 2 weeks ago
@jessicawoodin Could you please review composite.json to check the values for accuracy? Thanks.
Ready for second review. @jessicawoodin if you could please take a look at the updated typography.json
to double check the updated marginBottom values that'd be great.
Created separate ticket to look into combining figma export into single file: #577
Was there some further discussion I missed? If not, I think this ticket is a bit off. The font file for figma is already one file, it's just not grouped so things don't parse out into style/size/etc. in Figma as desired. This is the first I'm hearing of any desire to roll spacing/colors/font into a single file.
Had some discussion with @jessicawoodin but may have misinterpreted the desired outcome. Will clarify in stand-up.
Description of Change
This PR creates a new
composite.json
file which contains composite tokens made up from our font family, line height, paragraph spacing, and letter spacing tokens.filter/font/composite-npm
filter for font tokens of typecomposite
typescript/es6-declarations/composite
format to generate TS declarations composite tokensvalue
s of object typetypeof
font.styles
. I realizestyles
can be a little confusing alongsidestyle.json
which contains Bold, Italic, etc. but that file is for Figma only and not exported to NPM. Open to different names for this export.Check npm for sample output
Testing Packages
Screenshots/Video
N/A
Testing
Tested by importing into components package.
PR Checklist
Code reviewer validation:
changelog
label applied if it's to be included in the changelogPublish
If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:
main
into branchmain