department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
1 stars 0 forks source link

[Feature] Add assets package, Icon component, and reference files from component library #85

Closed narin closed 8 months ago

narin commented 9 months ago

Ticket department-of-veterans-affairs/va-mobile-app#50

Description of Change

Creates a new package called mobile-assets that houses our static files such as fonts and SVGs.

Testing Packages

Screenshots/Video

iOS fonts

Web

Button - Primary _ Storybook

iOS Icon

Web Icon

Icon - Primary _ Storybook

VA Mobile App test

Testing

PR Checklist

Code reviewer validation:

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

TimRoe commented 8 months ago

Could potentially be split to a separate ticket as this is already large, but did this AC get tested?

Test within VA mobile app that fonts and icons can be consumed

Assuming not with the lack of a components package alpha publish.

Also, this AC needs a ticket created:

Create separate ticket for flagship to update over to leveraging the assets package for fonts/SVGs

TimRoe commented 8 months ago

Somewhat against process, but should we publish assets 0.1.0 on this branch? If not, I think we'll need another PR to update components to use the right package before publishing components 0.4.0.

narin commented 8 months ago

Tested in the mobile app, added screenshots, created propagation ticket, resolved all suggestion or created tickets. Ready for another review.