department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

Update Link color across the CMS to meet WCAG 2.0 AAA contrast requirement #10046

Closed cjterdi closed 1 year ago

cjterdi commented 2 years ago

Description

Reference design tickets:

9916: The standard link style is blue underline with a hover style of a light blue background and no underline. This combination of blue does not pass the WCAG 2.0 AAA contrast requirements.

9917: An accessibility audit found that on all products and all tables, the main content listing has tables that do not pass WCAG accessibility standards for hover states. Table rows currently have a hover state that changes to light blue.

9915: On staging, the footer links have a background color of light blue which introduces an accessibility issue.

See approved link design

The following changes to the links are documented here: CMS DS Changelog

There is an additional condition for links in read-only content. To meet the same requirements we made an adjustment to the grey lighter color to #E5E3E1. See changes are documented here: CMS DS Changelog

Acceptance Criteria

CMS Team

Please check the team(s) that will do this work.

EWashb commented 2 years ago

As Edmund ramps up to the project, this may need to stretch. He is becoming familiar with the code base now and this is a good first task for him to do that.

EWashb commented 2 years ago

This ticket (the implementation) will stretch into sprint 65. however, this was not planned for sprint 64 specifically, just the work began as new dev was being onboarded.

EWashb commented 2 years ago

This could possibly be blocked for sprint 65 as Edmund is out sick

laflannery commented 2 years ago

This needs to be reopened after I was notified of some issues with some of the links. These are issues that Edmund and I had worked through and resolved previously. Examples are (but these are not all of them):

Screenshot of the first 3 image

Screenshot of the underlined tabs image

I also happened to see all these issues when I was reviewing the Admin toolbar PR - I feel like it's not related to why this is all appearing now but I also felt like I needed to say it just in case

EWashb commented 2 years ago

@edmund-dunn fixing this will need to take priority over all other work this sprint.

CC: @dawnpruitt

laflannery commented 2 years ago

I think the below updates should fix the issues:

I do think this will resolve the issues we are seeing and I don't think it will cause other interactions but obviously needs to be retested

laflannery commented 1 year ago

@edmund-dunn If you have a min can you take a look at this? This was the issue that got a bit confused and I think got reverted but then maybe we never went back and redid it. I'm not seeing your changes on Prod

dawnpruitt commented 1 year ago

@JayDarnell please reach out to @laflannery; this ticket isn't as clear cut as it first appears and she has the context you'll need. Thank you!

edmund-dunn commented 1 year ago

This was reverted because of regressions.