search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Developer log in stuck #10086

Open cmaeng opened 2 years ago

cmaeng commented 2 years ago

Describe the defect

After typing in the incorrect password when trying to use the "developer log in" i noticed a couple of things:

  1. the error at the top says, "1 error has been found: Username" when the username was actually correct. it was the password that failed
  2. if you click on the "Forgot your password?" link it will send a reregister email but won't allow you to try signing back on again

not sure if either are intentional, both are not critically urgent.

image (50).png

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'prod.cms.va.gov'
  2. Click on 'Developer log in'
  3. Type in an incorrect password
  4. See error message at the top referring to "Username"
  5. Click on "Forgot your password?"
  6. See that you can't attempt to retry

AC / Expected behavior

I would expect the error message to reference the password being incorrect and the ability to retry a password without needing to refresh the screen.

Desktop (please complete the following information if relevant, or delete)

Labels

(You can delete this section once it's complete)

CMS Team

Please check the team(s) that will do this work.

cmaeng commented 2 years ago

after talking through with @swirtSJW there are multiple factors that led to this behaving the way it does. coming up with a solution and having that be considered by the Drupal core security folks would most likely take more effort than it's worth. we'll leave this ticket on the board however, for at least the short term in case questions about this come up again.