department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
97 stars 69 forks source link

Empty table header cells in data tables in CMS #10133

Open laflannery opened 2 years ago

laflannery commented 2 years ago

Description

Still an issue in D10

There are data tables within the CMS that are missing content within the table header cells. Empty table header cells create confusion for users as they may not be able to fully understand the content in the associated table data cells.

Additional Context

List of tables where this was found (may not be the full list of all tables within the CMS):

Screenshot

image

Accessibility Standard

WCAG version 2.0 A, Criterion 1.3.1

Acceptance Criteria

CMS Team

Please check the team(s) that will do this work.

laflannery commented 1 year ago

Updated description to indicate which ones were remediated by update to office_hours module

laflannery commented 11 months ago

@ndouglas Does this need to be broken up into product tickets? It's not just one field type or markup that generates tables this way and would be one ticket?

ndouglas commented 11 months ago

@laflannery

For Benefit Hub(s), are you referring to this interface when you select Benefit Hubs?

Screenshot 2023-10-31 at 11 30 05 AM

Or are you referring to the field as it appears "at rest"?

Screenshot 2023-10-31 at 11 30 46 AM

laflannery commented 11 months ago

At rest, the modal doesn't actually have headers (which is neither here nor there at the moment but possibly something that should have another ticket)

ndouglas commented 11 months ago

@laflannery It seems most of these can probably be fixed in a hook that injects "Weight" (or something else?) in the table header for certain fields. I'll defer to @edmund-dunn and @tonytaylor on implementation, though. I think this can all remain in one ticket, unless either of them disagree.

laflannery commented 11 months ago

@ndouglas thank you for looking! It's definitely a lower priority but I started going through a lot of tickets today so I just wanted to split this up if I needed to. I really appreciate you taking the time!

srancour commented 5 months ago

This is something that still exists and should still be worked on.

gracekretschmer-metrostar commented 5 months ago

@JakeBapple I would like you to do a technical review of this work and @srancour could you do the UX/IA to determine what content should say?

Note, this is work that can be done when you have extra time and have finished any work related to sprint goals.

bapplejax commented 5 months ago

We may be able to add a site-wide markup solution to empty tds and ths by conditionally adding the aria-label="No value" to any cell in a table with no value. That work would be small in itself but the testing would need to be larger in scope and take up the bulk of the time. Estimated actual dev work would be about an hour to make the changes and spot check locally.