department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 68 forks source link

FE: Lovell support multiple list pages for event, stories, and news #10168

Closed swirtSJW closed 2 years ago

swirtSJW commented 2 years ago

Handle lists for Lovell

List pages for the following content types, need an approach to handle Lovell list items that appear in Lovell, VA, Tricare

AC's - Option C added 9/12

CMS side

Build three Lovell flavors of the list pages (both, va, tricare)

FE

outdated items ignore all below this.

~This one needs discussion. (meeting being set up with facilities, pws and sitewide) - 8/15 meeting had. This solution of multi-select will NOT be rolled out to all lists.~

~I will thread out some options in comments below.~

swirtSJW commented 2 years ago

Meeting concluded with multiselect not being a solution that would be rolled out to all lists in all systems. Our solution will have to just be limited to lovell.

swirtSJW commented 2 years ago

Option A

Cons:

  1. Tech debt on the CMS editorial interface side.
  2. A lot of graphql and frontend work (but not tech debt)

Pros:

  1. Impacts all list content types and their associated graphql queries.
swirtSJW commented 2 years ago

Option B

Cons:

  1. A lot of custom code scattered about.
  2. No real existing patterns for this

Pros:

  1. Gets us closer to a model we want for all list pages in the future
  2. May be able to use NextBuild for this as a POC
  3. Data is open as it would have static data source file exposed.
swirtSJW commented 2 years ago

Option C

3 list pages, VA, Tricare, Both For example, When a person creates an event it can appear on THIS location page - need to create a placeholder BOTH page that is never built, but from which the individual pages will populate when they are built

Cons:

  1. ??

Pros:

  1. All platypus code lives in the build step with the rest of the platypus code
davidmpickett commented 2 years ago

Sounds like Option C is the winner!

swirtSJW commented 2 years ago

Updated ACs to remove staff lists as they function differently and do not need special handling.

swirtSJW commented 2 years ago

Adding this diagram that I created for PR feedback so that we can refer back to it in the design image