search

department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Fix flaky content_editing.feature Cypress test #10219

Open ndouglas opened 2 years ago

ndouglas commented 2 years ago

Description

A test in content_editing.feature, "Log in and confirm that System-wide alerts can be created and edited", is flaky; it requires editing a certain node, and if that node is locked by another user, the test can fail.

Restrictions in place on the content types in question necessitate that the test be written in this way. We should investigate and try to find an alternative way.

This is likely to be a nightmare.

Acceptance Criteria

ndouglas commented 1 year ago

I'm... not happy about this test but I'm going to close this issue. Basically, we need a behavioral test covering this flow, and after some tweaks in previous PRs (#10220, #10880, etc) we don't really see failures here anymore. The purist in me is somewhat hurt, but I don't think this is necessary anymore.