FE: Remove Fetch of Forms File HEAD during PDF Click Event

dsasser commented 2 years ago

BLOCKER(s)

See https://github.com/department-of-veterans-affairs/va.gov-cms/issues/10562, the better approach may be to re-use the simpler javascript flow from the Form Search page
Blocked on confirming the business logic for why this was added, and whether it should instead be applied to both VA and VBA forms

Description

Update: This API call is unique to the download flow on Form Detail pages; the Form Search page doesn't have this extra API call.

During discovery performed under #10061, we identified a seemingly redundant HTTP call to fetch the HEAD of the linked Form PDF file, which is occurring during the PDF Click event. This only occurs if the PDF is hosted by www.va.gov (not vba.va.gov, or any other of the other domains).

Remove this HTTP call occurring during the PDF click event.

Here's where to find the big Mural board (pictured below).

VACMS-10061 - Discovery Form FE Workflow.png

Acceptance Criteria

[ ] Fully grok the entirety of the Mural created in #10061 for context of the extra API call (LINK TBD)
[ ] Validate that it's a good idea to remove this fetch
[ ] Remove the call
[ ] QA against relevant use cases

CMS Team

Please check the team(s) that will do this work.

[ ] Program
[ ] Platform CMS Team
[ ] Sitewide Crew
[ ] ⭐️ Sitewide CMS
[x] ⭐️ Public Websites
[ ] ⭐️ Facilities
[ ] ⭐️ User support

wesrowe commented 2 years ago

Updated issue to reflect that spike https://github.com/department-of-veterans-affairs/va.gov-cms/issues/10562 might be a better approach.

FranECross commented 2 months ago

Closing old iceboxed ticket.

department-of-veterans-affairs / va.gov-cms