Closed jilladams closed 1 year ago
The original list that Rachal provided in https://docs.google.com/spreadsheets/d/1LZjJIKZ-cteRxqwFIAbnAR2Sa32liP-5Y3WQ_UqZCKk/edit#gid=0 are all actually Facilities toggles, and have been handed off to Roger / David Shannon in Slack.
@RWEagans @dsinla FYI that in PW refinement today, Dave suggested that PW, Facilities, and Dave do the requested audit of feature flags as a joint meeting, since he holds so much history / context. I'll own scheduling the meeting.
related comment in facilities issue https://github.com/department-of-veterans-affairs/va.gov-cms/issues/10350#issuecomment-1225555067
Estimated at 5 initially, but then changed to 3 to align with this being only a spike. The implementation will be separate. Some of this discovery work has already been done prior to this estimate, but it seems like that fits into the total of 3. There shouldn't be too much left to do, but there's some.
The spreadsheet list in the AC has been updated with an indication of which flags can be deprecated / removed and some notes on the effort level for each.
Thanks! - looks like many many flags are either not mentioned in the code (vets-website / content-build) at all, or only mentioned in the flags file, so those could be removed. There are a couple I would love to get @ryguyk 's eyes on (in this sheet, the "Can be removed?"/"Notes" columns for Brian's assessment) just to measure twice before we cut once.
Checked in with @ryguyk via Slack to confirm if this can close. He flagged some marked Removable that need a 2nd look -- he will close loop tomorrow. Added to Sprint 71. FYI, @davidconlon / @wesrowe
Brief meeting with Ryan, Josh, Wes, me:
sign_in_service_enabled
. However: in most cases, this snake case is mapped to a camelCase version of the flag in vets-website/src/platform/utilities/feature-toggles/featureFlagNames.js
, e.g. signInServiceEnabled
. So in light of that, Step 1: I've updated the Sheet to flag which items need re-review for usage / how widely spread they are.
Step 2: How do we know for sure it's ours to remove?
Step 3: if it's used & we own the files: how do we decide if something that's widely spread could actually be removed?
Step 4: actual removal (will happen in separate tickets in this epic)
Some flippers that have been on for ages, e.g. show_events_v2
, can probably be removed. However to do that, need to:
For flippers that have been off for ages, it's a little more unclear why, so we'll need to interrogate what it's doing, if anything.
Moving from Review/QA back to Stretch, so we can review in an upcoming sprint, likely after Homepage work settles.
Google Sheet has been updated to reflect audit with “camel cased” flag names.
Bueno! Let's you, me, Ryan, Wes do a quick meeting on it to review the outcome, talk priority / lift, so Wes & I can start cutting tickets to remove the ones we can. Could you schedule?
Reviewed with Ryan, sheet updated with a few additional notes. Closing, and action items from here are:
Tickets created in the epic.
Description
Request from @RachalCassity: Console Services Team is evaluating site performance, and identified that feature toggles (Flipper) in vets-api and vets-website repos.
Feature toggles endpoint is called multiple times per page, and causes Sentry errors / site latency.
Proposed list of Ownership:
https://dvagov-my.sharepoint.com/:x:/g/personal/jill_adams1_va_gov/EWJYp5QIYQ5Bng7ynlMX9hIBxXjsVBNANaugiektKZ1fcQ
(shared with DaveC)Existing flags:
CMS Feature toggles follow up work
https://prod.cms.va.gov/admin/config/system/feature_toggle
Complete, no-op
@swirtSJW to follow up with a commit to remove these flags from code if they don't effectively disappear from config based on DB delete, based on #5855
Feature flippers follow up work
https://api.va.gov/flipper/features
Acceptance criteria