department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
98 stars 68 forks source link

Audit feature toggles for opportunities to retire #10350

Closed dsinla closed 2 years ago

dsinla commented 2 years ago

Description

Request from @RachalCassity:
Console Services Team is evaluating site performance, and identified feature toggles in vets-api and vets-website repos. Feature toggles endpoint is called multiple times per page, and causes Sentry errors / site latency.

8 of the 12 feature toggles on this list explicitly identify facility_locator:

Feature Flag Name Added to vets-website Team Removed
enrollment_verification 6 months ago vsa-public-websites-frontend No
facilities_ppms_suppress_all 12 months ago vsa-public-websites-frontend No
facilities_ppms_suppress_community_care 9 months ago vsa-public-websites-frontend No
facilities_ppms_suppress_pharmacies 11 months ago vsa-public-websites-frontend No
facility_locator_lat_long_only 9 months ago vsa-public-websites-frontend No
facility_locator_lighthouse_covid_vaccine_query 11 months ago vsa-public-websites-frontend No
facility_locator_show_health_connect_number 8 months ago vsa-public-websites-frontend No
facility_locator_predictive_location_search 11 months ago vsa-public-websites-frontend No
facility_locator_rails_engine 11 months ago vsa-public-websites-frontend No
facility_locator_restore_community_care_pagination 9 months ago vsa-public-websites-frontend No
facility_locator_show_community_cares 11 months ago vsa-public-websites-frontend No
facility_locator_show_operational_hours_special_instructions 11 months ago vsa-public-websites-frontend No

Link to Slack convo Related PW ticket

Acceptance Criteria

CMS Team

Please check the team(s) that will do this work.

swirtSJW commented 2 years ago

This should be done on a joint call with PWS, Facilites and Dave Conlon as well as a CMS engineer and a FE engineer from both teams.

On the call, engineers will need to search all three code bases for each flag to determine if they are used anywhere and can be removed.|

Include audit of CMS internal toggles with this same team

dsinla commented 2 years ago

Meeting held today 08/30. @swirtSJW @jilladams who is doing the summarizing task steps and taking stab at effort?

jilladams commented 2 years ago

@dsinla a Facilities front-end engineer will need to look through the list of Flippers owned by Facilities team, most likely.

dsinla commented 2 years ago

Closing - audit completed. Executing will be done next sprint https://github.com/department-of-veterans-affairs/va.gov-cms/issues/10656